Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1494341
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver |
| Date | 2016-10-01 05:10 +0200 |
| Message-ID | <sniQx-2AT-3@gated-at.bofh.it> (permalink) |
| References | <smxyh-5qo-9@gated-at.bofh.it> <smNMJ-7br-11@gated-at.bofh.it> <sneWB-8fw-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 09/30/2016 03:54 PM, Dmitry Torokhov wrote:
> On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote:
>> On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote:
>>
>>> Instantiating the rmi4 I2C transport driver without interrupts assigned
>>> (for example using manual i2c instantiation from the command line)
>>> caused the driver to fail to load, but it does not clean up its
>>> regulator or transport device registrations. Result is a crash at a later
>>> time, for example when rebooting the system.
>>>
>>> Fixes: 946c8432aab0 ("Input: synaptics-rmi4 - support regulator supplies")
>>
>> Sorry for that.
>>
>>> Fixes: fdf51604f104 ("Input: synaptics-rmi4 - add I2C transport driver")
>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Applied, thank you.
>
> It looks like we have similar issue in rmi_spi.c. Can I get another
> patch?
>
Sure.
Guenter
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Guenter Roeck <linux@roeck-us.net> - 2016-09-29 02:40 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-09-29 20:00 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-01 01:00 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-01 01:10 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Guenter Roeck <linux@roeck-us.net> - 2016-10-01 05:50 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Andrew Duggan <andrew@duggan.us> - 2016-10-01 19:40 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Guenter Roeck <linux@roeck-us.net> - 2016-10-01 19:50 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Andrew Duggan <andrew@duggan.us> - 2016-10-01 20:00 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-01 21:10 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Guenter Roeck <linux@roeck-us.net> - 2016-10-01 22:50 +0200
Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver Guenter Roeck <linux@roeck-us.net> - 2016-10-01 05:10 +0200
csiph-web