Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to determine roll-forward recovery

From	Jaegeuk Kim <jaegeuk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to determine roll-forward recovery
Date	2016-10-01 03:00 +0200
Message-ID	<sngOJ-YA-3@gated-at.bofh.it> (permalink)
References	<sjjrP-5Ci-7@gated-at.bofh.it> <sn9Dz-4Pc-3@gated-at.bofh.it> <snglH-NW-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Oct 01, 2016 at 08:26:20AM +0800, Chao Yu wrote:
> On 2016/10/1 1:10, Jaegeuk Kim wrote:
> > @@ -1089,6 +1079,9 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> >  	if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
> >  		set_ckpt_flags(ckpt, CP_FSCK_FLAG);
> >  
> > +	/* set this flag to activate crc|cp_ver for recovery */
> > +	set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG);
> 
> Should let new introduced spinlock cover the flag updating in ("f2fs: introduce
> cp_lock to protect updating of ckpt_flags").

Fixed.

http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=aaec2b1d18792a5f27b69ff37f34f43f89f5aa3b

Thank you. :)

> 
> Thanks,

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2 v2] f2fs: use crc and cp version to determine  roll-forward recovery Jaegeuk Kim <jaegeuk@kernel.org> - 2016-09-30 19:20 +0200
  Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to  determine roll-forward recovery Chao Yu <chao@kernel.org> - 2016-10-01 02:30 +0200
    Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to  determine roll-forward recovery Jaegeuk Kim <jaegeuk@kernel.org> - 2016-10-01 03:00 +0200

csiph-web