Re: [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner
Date	2016-10-01 00:30 +0200
Message-ID	<snetz-84M-1@gated-at.bofh.it> (permalink)
References	<s4Joe-2de-5@gated-at.bofh.it> <s4Joe-2de-17@gated-at.bofh.it> <smLKV-5Vi-3@gated-at.bofh.it> <smYyu-60F-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 30, 2016 at 01:21:27AM -0400, David Miller wrote:
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Date: Thu, 29 Sep 2016 08:46:05 -0700
> 
> > Hi David,
> > 
> > On Wed, Aug 10, 2016 at 2:36 PM, Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> >> If net namespace is attached to a user namespace let's make container's
> >> root owner of sysctls affecting said network namespace instead of global
> >> root.
> >>
> >> This also allows us to clean up net_ctl_permissions() because we do not
> >> need to fudge permissions anymore for the container's owner since it now
> >> owns the objects in question.
> >>
> >> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > 
> > I was looking at linux-next today, and I noticed that, when you merged
> > my patch, you basically reverted the following commit:
> > 
> > commit d6e0d306449bcb5fa3c80e7a3edf11d45abf9ae9
> > Author: Tyler Hicks <tyhicks@canonical.com>
> > Date:   Thu Jun 2 23:43:22 2016 -0500
> > 
> >     net: Use ns_capable_noaudit() when determining net sysctl permissions
> 
> Please send me a fixup patch for this, sorry.

Just did, look for <20160930222431.GA30208@dtor-ws>

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/3] net: make net namespace sysctls belong to  container's owner Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-09-29 17:50 +0200
  Re: [PATCH v2 3/3] net: make net namespace sysctls belong to  container's owner David Miller <davem@davemloft.net> - 2016-09-30 07:30 +0200
    Re: [PATCH v2 3/3] net: make net namespace sysctls belong to  container's owner Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-01 00:30 +0200

csiph-web