Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494233

Re: [PATCH 1/3] netfilter: nf_tables: avoid uninitialized variable warning

Show all headers | View raw

On Fri, Sep 30, 2016 at 07:47:49PM +0200, Pablo Neira Ayuso wrote:
> On Fri, Sep 30, 2016 at 06:05:34PM +0200, Arnd Bergmann wrote:
> > The newly added nft_range_eval() function handles the two possible
> > nft range operations, but as the compiler warning points out,
> > any unexpected value would lead to the 'mismatch' variable being
> > used without being initialized:
> > 
> > net/netfilter/nft_range.c: In function 'nft_range_eval':
> > net/netfilter/nft_range.c:45:5: error: 'mismatch' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > 
> > This can be trivially avoided by added a 'default:' clause.
> 
> Applied this patch, I took Aaron's and Pai's patches instead.

Looking at this again, I know uninitialized_var() has been discussed
as not nice since it can hide bugs behind. But if I fix the existing
code to validate priv->op from _init() (this is currently broken), we
can probably use this so save extra code in the packet path for a case
that is not going to happen.

Let me know, thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] netfilter: nf_tables: avoid uninitialized variable warning Arnd Bergmann <arnd@arndb.de> - 2016-09-30 18:10 +0200
  [PATCH 3/3] netfilter: xt_hashlimit: uses div_u64 for division Arnd Bergmann <arnd@arndb.de> - 2016-09-30 18:10 +0200
    Re: [PATCH 3/3] netfilter: xt_hashlimit: uses div_u64 for division Eric Dumazet <eric.dumazet@gmail.com> - 2016-09-30 18:40 +0200
      Re: [PATCH 3/3] netfilter: xt_hashlimit: uses div_u64 for division Vishwanath Pai <vpai@akamai.com> - 2016-09-30 19:30 +0200
      Re: [PATCH 3/3] netfilter: xt_hashlimit: uses div_u64 for division Arnd Bergmann <arnd@arndb.de> - 2016-09-30 19:50 +0200
  Re: [PATCH 1/3] netfilter: nf_tables: avoid uninitialized variable  warning Pablo Neira Ayuso <pablo@netfilter.org> - 2016-09-30 19:50 +0200
    Re: [PATCH 1/3] netfilter: nf_tables: avoid uninitialized variable  warning Pablo Neira Ayuso <pablo@netfilter.org> - 2016-09-30 20:50 +0200

csiph-web