Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1494037

Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs

From Richard Genoud <richard.genoud@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs
Date 2016-09-30 13:50 +0200
Message-ID <sn4ud-1eM-5@gated-at.bofh.it> (permalink)
References <sn1PN-7WT-13@gated-at.bofh.it> <sn1PN-7WT-19@gated-at.bofh.it> <sn294-8iN-7@gated-at.bofh.it> <sn3Rv-11r-15@gated-at.bofh.it> <sn41c-14H-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2016-09-30 13:16 GMT+02:00 Alexandre Belloni
<alexandre.belloni@free-electrons.com>:
> On 30/09/2016 at 13:04:28 +0200, Richard Genoud wrote :
>> Anyway, the problematics setups are all the setups with USMODE_HWHS
>> enabled on platform without Fifos or PDC,
>> i.e. all platforms but sama5d2 (Cyrille, correct me if I'm wrong).
>>
>
> This is a wrong assumption, at91rm9200 to at91sam9g45 all have a pdc.
> Please, don't break those platforms.
>
> The only affected platforms are sam9x5, sama5d3 and sama5d4.
Have you tested them ?

And why are you saying that rm9200 and g45 will be broken with this patch ?
If they have a pdc, they will fall in the case:
(atmel_use_pdc_rx(port) || atmel_use_fifo(port))
and thus use:
mode |= ATMEL_US_USMODE_HWHS;

won't they ?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs Richard Genoud <richard.genoud@gmail.com> - 2016-09-30 11:00 +0200
  Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-09-30 11:20 +0200
    Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs Richard Genoud <richard.genoud@gmail.com> - 2016-09-30 13:10 +0200
      Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-09-30 13:20 +0200
        Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs Richard Genoud <richard.genoud@gmail.com> - 2016-09-30 13:50 +0200
          Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-09-30 14:00 +0200
            Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs Richard Genoud <richard.genoud@gmail.com> - 2016-09-30 14:30 +0200
      Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-10-04 09:30 +0200
        Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with  GPIOs Richard Genoud <richard.genoud@gmail.com> - 2016-10-07 17:30 +0200

csiph-web