Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494023

[tip:x86/urgent] x86/vdso: Fix building on big endian host

Show all headers | View raw

Commit-ID:  e4aad64597d7a2455a541f904365b48d607916db
Gitweb:     http://git.kernel.org/tip/e4aad64597d7a2455a541f904365b48d607916db
Author:     Segher Boessenkool <segher@kernel.crashing.org>
AuthorDate: Thu, 29 Sep 2016 11:51:00 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 30 Sep 2016 12:37:40 +0200

x86/vdso: Fix building on big endian host

We need to call GET_LE to read hdr->e_type.

Fixes: 57f90c3dfc75 ("x86/vdso: Error out if the vDSO isn't a valid DSO")
Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
Acked-by: Andy Lutomirski <luto@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org
Link: http://lkml.kernel.org/r/20160929193442.GA16617@gate.crashing.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/entry/vdso/vdso2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/entry/vdso/vdso2c.h b/arch/x86/entry/vdso/vdso2c.h
index 4f74119..3dab75f 100644
--- a/arch/x86/entry/vdso/vdso2c.h
+++ b/arch/x86/entry/vdso/vdso2c.h
@@ -22,7 +22,7 @@ static void BITSFUNC(go)(void *raw_addr, size_t raw_len,
 
 	ELF(Phdr) *pt = (ELF(Phdr) *)(raw_addr + GET_LE(&hdr->e_phoff));
 
-	if (hdr->e_type != ET_DYN)
+	if (GET_LE(&hdr->e_type) != ET_DYN)
 		fail("input is not a shared object\n");
 
 	/* Walk the segment table. */

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: linux-next: Tree for Jul 21 Segher Boessenkool <segher@kernel.crashing.org> - 2016-09-29 21:40 +0200
  Re: linux-next: Tree for Jul 21 Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-30 01:20 +0200
    Re: linux-next: Tree for Jul 21 Andy Lutomirski <luto@amacapital.net> - 2016-09-30 01:30 +0200
  [tip:x86/urgent] x86/vdso: Fix building on big endian host tip-bot for Segher Boessenkool <tipbot@zytor.com> - 2016-09-30 12:50 +0200

csiph-web