Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1494015

Re: [PATCH 1/2] perf intel-pt-decoder: Report instruction bytes and length in sample

From Adrian Hunter <adrian.hunter@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] perf intel-pt-decoder: Report instruction bytes and length in sample
Date 2016-09-30 12:20 +0200
Message-ID <sn358-vu-17@gated-at.bofh.it> (permalink)
References <smX9n-4UQ-3@gated-at.bofh.it>
Organization Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki

Show all headers | View raw


On 30/09/16 06:49, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Change the Intel PT decoder to pass up the length and the instruction
> bytes of the decoded or sampled instruction in the perf sample.
> 
> The decoder already knows this information, we just need to pass it
> up. Since it is only a couple of movs it is not very expensive.

The decoder doesn't always fill the instruction buffer because it caches the
results from walking basic blocks.  That means the bytes from the last
instruction in the basic block would need to be added to the cache.

I wonder if we shouldn't look at something more sophisticated e.g. a python
script that can do full disassembly.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] perf intel-pt-decoder: Report instruction bytes and length in sample Andi Kleen <andi@firstfloor.org> - 2016-09-30 06:00 +0200
  Re: [PATCH 1/2] perf intel-pt-decoder: Report instruction bytes and  length in sample Adrian Hunter <adrian.hunter@intel.com> - 2016-09-30 12:20 +0200
    Re: [PATCH 1/2] perf intel-pt-decoder: Report instruction bytes and  length in sample Andi Kleen <andi@firstfloor.org> - 2016-10-04 02:40 +0200

csiph-web