Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in JSON format

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in JSON format
Date	2016-09-30 11:20 +0200
Message-ID	<sn294-8iN-5@gated-at.bofh.it> (permalink)
References	(5 earlier) <slzCa-1yg-19@gated-at.bofh.it> <slFHz-5oB-5@gated-at.bofh.it> <slHzI-6zZ-37@gated-at.bofh.it> <sm1oK-260-13@gated-at.bofh.it> <smS01-1M3-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 29, 2016 at 07:19:48PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Sep 27, 2016 at 04:18:46PM +0200, Jiri Olsa escreveu:
> > On Mon, Sep 26, 2016 at 09:59:54AM -0700, Andi Kleen wrote:
> > > On Mon, Sep 26, 2016 at 12:03:43PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Mon, Sep 26, 2016 at 10:35:33AM +0200, Jiri Olsa escreveu:
> > > > > ping.. is that working for you? IMO we can include this
> > > > > as additional patch to the set..
> > > > 
> > > > No, it doesn't fails to build on the first cross env I tried, fixing it
> > > > now, resulting patch:
> > > 
> > > Yes it shouldn't be difficult to fix cross building. I don't think
> > > there are any fundamental problems.
> > 
> > right, how about attached patch
> > 
> > Arnaldo,
> > could you please try it on cross build.. I still dont have setup for that :-\
> > 
> > thanks,
> > jirka
> 
> So, this makes it work for me in one of the cross build envs I have (all
> in https://hub.docker.com/r/acmel/) if I apply this patch on top:
> 
> diff --git a/tools/build/Makefile b/tools/build/Makefile
> index 653faee2a055..8332959fbca4 100644
> --- a/tools/build/Makefile
> +++ b/tools/build/Makefile
> @@ -42,7 +42,7 @@ $(OUTPUT)fixdep-in.o: FORCE
>  	$(Q)$(MAKE) $(build)=fixdep
>  
>  $(OUTPUT)fixdep: $(OUTPUT)fixdep-in.o
> -	$(QUIET_LINK)$(CC) $(LDFLAGS) -o $@ $<
> +	$(QUIET_LINK)$(HOSTCC) $(LDFLAGS) -o $@ $<
>  
>  FORCE:
>  
> -------------------
> 
> I've broken up the patch into multiple ones, to get first fixdep
> working, then to move to jevents, I'm putting this on a
> tmp.perf/hostprog branch till I've tested it all.

looks great, thanks

jirka

Thread

Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in  JSON format Jiri Olsa <jolsa@redhat.com> - 2016-09-26 10:40 +0200
  Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in  JSON format Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-26 17:10 +0200
    Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in  JSON format Andi Kleen <andi@firstfloor.org> - 2016-09-26 19:10 +0200
      Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in  JSON format Jiri Olsa <jolsa@redhat.com> - 2016-09-27 16:20 +0200
        Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in  JSON format Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-30 00:30 +0200
          Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in  JSON format Jiri Olsa <jolsa@redhat.com> - 2016-09-30 11:20 +0200
        [tip:perf/urgent] tools build: Add support for host programs format tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-10-04 10:20 +0200
        [tip:perf/urgent] perf jevents: Program to convert JSON file tip-bot for Andi Kleen <tipbot@zytor.com> - 2016-10-04 10:20 +0200
        [tip:perf/urgent] tools build: Make fixdep a hostprog tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-10-04 10:20 +0200

csiph-web