Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1492938
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 08/16] md/bitmap: Rename a jump label in location_store() |
| Date | 2016-09-28 22:00 +0200 |
| Message-ID | <smtbj-2Ad-5@gated-at.bofh.it> (permalink) |
| References | <qEuGl-43C-5@gated-at.bofh.it> <sm3JT-3si-3@gated-at.bofh.it> <sm3Tz-3vI-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
SF Markus Elfring <elfring@users.sourceforge.net> writes:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 27 Sep 2016 15:46:22 +0200
>
> Adjust jump labels according to the current Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/md/bitmap.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Sorry but this patch is just plain ridiculous. It does not improve the
code in any shape or form.
'out' as a label is perfectly legitimate and just as good as 'unlock'.
Jes
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 41d99fd..22fa09a 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -2187,11 +2187,11 @@ location_store(struct mddev *mddev, const char *buf, size_t len)
> if (mddev->pers) {
> if (!mddev->pers->quiesce) {
> rv = -EBUSY;
> - goto out;
> + goto unlock;
> }
> if (mddev->recovery || mddev->sync_thread) {
> rv = -EBUSY;
> - goto out;
> + goto unlock;
> }
> }
>
> @@ -2200,7 +2200,7 @@ location_store(struct mddev *mddev, const char *buf, size_t len)
> /* bitmap already configured. Only option is to clear it */
> if (strncmp(buf, "none", 4) != 0) {
> rv = -EBUSY;
> - goto out;
> + goto unlock;
> }
> if (mddev->pers) {
> mddev->pers->quiesce(mddev, 1);
> @@ -2221,23 +2221,23 @@ location_store(struct mddev *mddev, const char *buf, size_t len)
> else if (strncmp(buf, "file:", 5) == 0) {
> /* Not supported yet */
> rv = -EINVAL;
> - goto out;
> + goto unlock;
> } else {
> if (buf[0] == '+')
> rv = kstrtoll(buf+1, 10, &offset);
> else
> rv = kstrtoll(buf, 10, &offset);
> if (rv)
> - goto out;
> + goto unlock;
> if (offset == 0) {
> rv = -EINVAL;
> - goto out;
> + goto unlock;
> }
> if (mddev->bitmap_info.external == 0 &&
> mddev->major_version == 0 &&
> offset != mddev->bitmap_info.default_offset) {
> rv = -EINVAL;
> - goto out;
> + goto unlock;
> }
> mddev->bitmap_info.offset = offset;
> if (mddev->pers) {
> @@ -2255,7 +2255,7 @@ location_store(struct mddev *mddev, const char *buf, size_t len)
> mddev->pers->quiesce(mddev, 0);
> if (rv) {
> bitmap_destroy(mddev);
> - goto out;
> + goto unlock;
> }
> }
> }
> @@ -2268,7 +2268,7 @@ location_store(struct mddev *mddev, const char *buf, size_t len)
> md_wakeup_thread(mddev->thread);
> }
> rv = 0;
> -out:
> +unlock:
> mddev_unlock(mddev);
> if (rv)
> return rv;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/16] md/bitmap: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 18:50 +0200
[PATCH 03/16] md/bitmap: Delete an unnecessary variable initialisation in bitmap_storage_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 18:50 +0200
[PATCH 02/16] md/bitmap: Move an assignment for the variable "offset" in bitmap_storage_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 18:50 +0200
[PATCH 01/16] md/bitmap: Use kmalloc_array() in bitmap_storage_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 18:50 +0200
Re: [PATCH 01/16] md/bitmap: Use kmalloc_array() in bitmap_storage_alloc() Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-09-28 22:00 +0200
[PATCH 09/16] md/bitmap: Rename a jump label in bitmap_copy_from_slot() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:00 +0200
[PATCH 08/16] md/bitmap: Rename a jump label in location_store() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:00 +0200
Re: [PATCH 08/16] md/bitmap: Rename a jump label in location_store() Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-09-28 22:00 +0200
Re: [PATCH 08/16] md/bitmap: Rename a jump label in location_store() Guoqing Jiang <gqjiang@suse.com> - 2016-09-29 05:20 +0200
[PATCH 06/16] md/bitmap: Return directly after a failed kzalloc() in bitmap_resize() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:00 +0200
[PATCH 11/16] md/bitmap: Rename a jump label in bitmap_init_from_disk() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:00 +0200
[PATCH 04/16] md/bitmap: Improve another size determination in bitmap_storage_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:00 +0200
[PATCH 05/16] md/bitmap: Return directly after a failed bitmap_storage_alloc() in bitmap_resize() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:00 +0200
[PATCH 07/16] md/bitmap: Replace a kzalloc() call by kcalloc() in bitmap_resize() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:00 +0200
[PATCH 10/16] md/bitmap: Rename a jump label in bitmap_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:00 +0200
[PATCH 15/16] md/bitmap: Add spaces around three comparison operators SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:10 +0200
[PATCH 12/16] md/bitmap: One check less in read_page() at the end SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:10 +0200
Re: [PATCH 12/16] md/bitmap: One check less in read_page() at the end Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-28 09:40 +0200
[PATCH 16/16] md/bitmap: Delete an unwanted space in read_sb_page() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:10 +0200
[PATCH 14/16] md/bitmap: Delete unnecessary braces in bitmap_resize() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:10 +0200
[PATCH 13/16] md/bitmap: Adjust checks for null pointers in 11 functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-27 19:10 +0200
csiph-web