Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1492692
| From | Sergio Paracuellos <sergio.paracuellos@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 45/87] staging: wlang-ng: avoid new typedef: hfa384x_usbin_t |
| Date | 2016-09-28 18:40 +0200 |
| Message-ID | <smq3M-If-19@gated-at.bofh.it> (permalink) |
| References | <smpU5-Ee-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef hfa384x_usbin_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 6 +++---
drivers/staging/wlan-ng/hfa384x_usb.c | 21 +++++++++++----------
2 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 2365edc..f715f5f 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -909,7 +909,7 @@ struct hfa384x_usb_error {
struct hfa384x_usb_rmemreq rmemreq;
} __packed;
-typedef union hfa384x_usbin {
+union hfa384x_usbin {
__le16 type;
struct hfa384x_usb_rxfrm rxfrm;
struct hfa384x_usb_txfrm txfrm;
@@ -922,7 +922,7 @@ struct hfa384x_usb_error {
struct hfa384x_usb_bufavail bufavail;
struct hfa384x_usb_error usberror;
u8 boguspad[3000];
-} __packed hfa384x_usbin_t;
+} __packed;
/*--------------------------------------------------------------------
* PD record structures.
@@ -1184,7 +1184,7 @@ typedef void (*ctlx_usercb_t) (struct hfa384x *hw,
size_t outbufsize;
union hfa384x_usbout outbuf; /* pkt buf for OUT */
- hfa384x_usbin_t inbuf; /* pkt buf for IN(a copy) */
+ union hfa384x_usbin inbuf; /* pkt buf for IN(a copy) */
CTLX_STATE state; /* Tracks running state */
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index d76ec2a..9203880 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -169,13 +169,13 @@ enum cmd_mode {
static void hfa384x_usbin_callback(struct urb *urb);
static void
-hfa384x_usbin_txcompl(struct wlandevice *wlandev, hfa384x_usbin_t *usbin);
+hfa384x_usbin_txcompl(struct wlandevice *wlandev, union hfa384x_usbin *usbin);
static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb);
-static void hfa384x_usbin_info(struct wlandevice *wlandev, hfa384x_usbin_t *usbin);
+static void hfa384x_usbin_info(struct wlandevice *wlandev, union hfa384x_usbin *usbin);
-static void hfa384x_usbin_ctlx(hfa384x_t *hw, hfa384x_usbin_t *usbin,
+static void hfa384x_usbin_ctlx(hfa384x_t *hw, union hfa384x_usbin *usbin,
int urb_status);
/*---------------------------------------------------*/
@@ -327,7 +327,7 @@ static int submit_rx_urb(hfa384x_t *hw, gfp_t memflags)
struct sk_buff *skb;
int result;
- skb = dev_alloc_skb(sizeof(hfa384x_usbin_t));
+ skb = dev_alloc_skb(sizeof(union hfa384x_usbin));
if (!skb) {
result = -ENOMEM;
goto done;
@@ -336,7 +336,7 @@ static int submit_rx_urb(hfa384x_t *hw, gfp_t memflags)
/* Post the IN urb */
usb_fill_bulk_urb(&hw->rx_urb, hw->usb,
hw->endp_in,
- skb->data, sizeof(hfa384x_usbin_t),
+ skb->data, sizeof(union hfa384x_usbin),
hfa384x_usbin_callback, hw->wlandev);
hw->rx_urb_skb = skb;
@@ -2990,7 +2990,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
{
struct wlandevice *wlandev = urb->context;
hfa384x_t *hw;
- hfa384x_usbin_t *usbin = (hfa384x_usbin_t *)urb->transfer_buffer;
+ union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
struct sk_buff *skb = NULL;
int result;
int urb_status;
@@ -3166,7 +3166,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
* Call context:
* interrupt
----------------------------------------------------------------*/
-static void hfa384x_usbin_ctlx(hfa384x_t *hw, hfa384x_usbin_t *usbin,
+static void hfa384x_usbin_ctlx(hfa384x_t *hw, union hfa384x_usbin *usbin,
int urb_status)
{
hfa384x_usbctlx_t *ctlx;
@@ -3286,7 +3286,7 @@ static void hfa384x_usbin_ctlx(hfa384x_t *hw, hfa384x_usbin_t *usbin,
* interrupt
----------------------------------------------------------------*/
static void hfa384x_usbin_txcompl(struct wlandevice *wlandev,
- hfa384x_usbin_t *usbin)
+ union hfa384x_usbin *usbin)
{
u16 status;
@@ -3318,7 +3318,7 @@ static void hfa384x_usbin_txcompl(struct wlandevice *wlandev,
----------------------------------------------------------------*/
static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
{
- hfa384x_usbin_t *usbin = (hfa384x_usbin_t *)skb->data;
+ union hfa384x_usbin *usbin = (union hfa384x_usbin *)skb->data;
hfa384x_t *hw = wlandev->priv;
int hdrlen;
struct p80211_rxmeta *rxmeta;
@@ -3517,7 +3517,8 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
* Call context:
* interrupt
----------------------------------------------------------------*/
-static void hfa384x_usbin_info(struct wlandevice *wlandev, hfa384x_usbin_t *usbin)
+static void hfa384x_usbin_info(struct wlandevice *wlandev,
+ union hfa384x_usbin *usbin)
{
usbin->infofrm.info.framelen =
le16_to_cpu(usbin->infofrm.info.framelen);
--
1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/87] Fix some style warnings in hfa384x.h Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:30 +0200
[PATCH 63/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 38/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 66/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 40/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 61/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 68/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 37/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 45/87] staging: wlang-ng: avoid new typedef: hfa384x_usbin_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 06/87] staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 71/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 69/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 76/87] staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 72/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 55/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 54/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_measurements_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 52/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 80/87] staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 44/87] staging: wlang-ng: avoid new typedef: hfa384x_usbout_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 01/87] staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 75/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 56/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_compc_measurements_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 64/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 73/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 46/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 78/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 58/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 67/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 65/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 49/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 60/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 50/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 57/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 41/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 48/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 05/87] staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 59/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 36/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 35/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 39/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 79/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 03/87] staging: wlang-ng: Fix block comments style warnings in hfa384x.h Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 62/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 81/87] staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 82/87] staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 70/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 51/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 53/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 74/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 77/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testsp_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:40 +0200
[PATCH 32/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 07/87] staging: wlang-ng: avoid new typedef: hfa384x_authenticateStation_data_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 22/87] staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 16/87] staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 33/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 30/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 11/87] staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 19/87] staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 34/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 25/87] staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 17/87] staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 20/87] staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 09/87] staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 31/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 21/87] staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 23/87] staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 27/87] staging: wlang-ng: avoid new typedef: hfa384x_infodata_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 15/87] staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 08/87] staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 43/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 18/87] staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 10/87] staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 28/87] staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 29/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 42/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 47/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 12/87] staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
Re: [PATCH 00/87] Fix some style warnings in hfa384x.h Giedrius Statkevičius <giedrius.statkevicius@gmail.com> - 2016-09-28 18:50 +0200
Re: [PATCH 00/87] Fix some style warnings in hfa384x.h Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 19:50 +0200
[PATCH 26/87] staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 14/87] staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 24/87] staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
[PATCH 13/87] staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-28 18:50 +0200
csiph-web