Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1492555

Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

Show all headers | View raw

On Wed, Sep 28, 2016 at 03:55:32PM +0530, shyam saini wrote:
> Remove the explicit NULL comparison and rewrite in a compact form and
> fixed switch case indentation issue.

If you need "and" in a subject: line for a patch, that's a huge hint
that this needs to be at least 2 patches.

Please only ever do "one type of thing" in a single patch.  And no, that
one thing can not be "fix all coding style issues" :)

Please break this up into multiple patches and resend it.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style shyam saini <mayhs11saini@gmail.com> - 2016-09-28 12:30 +0200
  Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL  comparison and Fixed coding style Greg KH <gregkh@linuxfoundation.org> - 2016-09-28 14:10 +0200

csiph-web