Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate()

From	Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate()
Date	2016-09-28 14:00 +0200
Message-ID	<smlGN-69R-9@gated-at.bofh.it> (permalink)
References	<sm2E9-2Ll-3@gated-at.bofh.it> <smldL-60u-1@gated-at.bofh.it> <smlx8-66C-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 28/09/16 14:43, Bartosz Golaszewski wrote:

> how far is far enough to emit a warning? On da850 the requested rate
> is 228000000 Hz, while the calculated divider is 6, which results in
> the real rate of 225000000 Hz. This is less than 1% difference -
> should we take this value as reference?

Good question, and I don't have a clear answer. But I think the point is
just to inform the user that it's likely that his LCD won't work
properly, and often LCDs are quite tolerant about the pclk. So diff less
than 1% is just fine. Even 5% sounds still fine to me, perhaps even 10%.
I think we just have to try something out, and adjust it if people get
the message too often.

 Tomi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm: tilcdc: add a workaround for failed clk_set_rate() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-27 17:40 +0200
  Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate() Jyri Sarha <jsarha@ti.com> - 2016-09-28 13:00 +0200
  Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate() Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-09-28 13:30 +0200
    Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-28 13:50 +0200
      Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate() Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-09-28 14:00 +0200

csiph-web