Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1492411

[PATCH 4.7 48/69] MIPS: Avoid a BUG warning during prctl(PR_SET_FP_MODE, ...)

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject [PATCH 4.7 48/69] MIPS: Avoid a BUG warning during prctl(PR_SET_FP_MODE, ...)
Date 2016-09-28 11:20 +0200
Message-ID <smjbZ-4Pw-87@gated-at.bofh.it> (permalink)
References <smj2h-4LM-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


4.7-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Marcin Nowakowski <marcin.nowakowski@imgtec.com>

commit b244614a60ab7ce54c12a9cbe15cfbf8d79d0967 upstream.

cpu_has_fpu macro uses smp_processor_id() and is currently executed
with preemption enabled, that triggers the warning at runtime.

It is assumed throughout the kernel that if any CPU has an FPU, then all
CPUs would have an FPU as well, so it is safe to perform the check with
preemption enabled - change the code to use raw_ variant of the check to
avoid the warning.

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14125/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/mips/kernel/process.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- a/arch/mips/kernel/process.c
+++ b/arch/mips/kernel/process.c
@@ -591,14 +591,14 @@ int mips_set_process_fp_mode(struct task
 		return -EOPNOTSUPP;
 
 	/* Avoid inadvertently triggering emulation */
-	if ((value & PR_FP_MODE_FR) && cpu_has_fpu &&
-	    !(current_cpu_data.fpu_id & MIPS_FPIR_F64))
+	if ((value & PR_FP_MODE_FR) && raw_cpu_has_fpu &&
+	    !(raw_current_cpu_data.fpu_id & MIPS_FPIR_F64))
 		return -EOPNOTSUPP;
-	if ((value & PR_FP_MODE_FRE) && cpu_has_fpu && !cpu_has_fre)
+	if ((value & PR_FP_MODE_FRE) && raw_cpu_has_fpu && !cpu_has_fre)
 		return -EOPNOTSUPP;
 
 	/* FR = 0 not supported in MIPS R6 */
-	if (!(value & PR_FP_MODE_FR) && cpu_has_fpu && cpu_has_mips_r6)
+	if (!(value & PR_FP_MODE_FR) && raw_cpu_has_fpu && cpu_has_mips_r6)
 		return -EOPNOTSUPP;
 
 	/* Proceed with the mode switch */

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 4.7 00/69] 4.7.6-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:10 +0200
  [PATCH 4.7 06/69] ocfs2/dlm: fix race between convert and migration Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:10 +0200
  [PATCH 4.7 56/69] PM / hibernate: Restore processor state before using per-CPU variables Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 47/69] MIPS: Remove compact branch policy Kconfig entries Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 12/69] Makefile: Mute warning for __builtin_return_address(>0) for tracing only Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 66/69] kasan: avoid overflowing quarantine size on low memory systems Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 52/69] libceph: add an ONSTACK initializer for oids Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 38/69] btrfs: ensure that file descriptor used with subvol ioctls is a dir Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 57/69] PM / hibernate: Fix rtree_next_node() to avoid walking off list ends Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 51/69] x86/mm/pat: Prevent hang during boot when mapping pages Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 68/69] iw_cxgb4: stop MPA_REPLY timer when disconnecting Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 32/69] tracing: Move mutex to protect against resetting of seq data Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 13/69] xfs: prevent dropping ioend completions during buftarg wait Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 64/69] qxl: check for kmap failures Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 43/69] i2c: qup: skip qup_i2c_suspend if the device is already runtime suspended Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 27/69] reset: Return -ENOTSUPP when not configured Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 45/69] MIPS: SMP: Fix possibility of deadlock when bringing CPUs online Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 09/69] autofs: use dentry flags to block walks during expire Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 49/69] MIPS: Add a missing ".set pop" in an early commit Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 34/69] can: flexcan: fix resume function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 62/69] igb: fix adjusting PTP timestamps for Tx/Rx latency Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 10/69] Disable "maybe-uninitialized" warning globally Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 61/69] ixgbe: Re-enable ability to toggle VLAN filtering Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 53/69] ceph: fix symbol versioning for ceph_monc_do_statfs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 40/69] irqchip/mips-gic: Fix local interrupts Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 46/69] MIPS: vDSO: Fix Malta EVA mapping to vDSO page structs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 29/69] power: reset: hisi-reboot: Unmap region obtained by of_iomap Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 41/69] i2c-eg20t: fix race between i2c init and interrupt enable Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 60/69] ixgbe: Force VLNCTRL.VFE to be set in all VMDq paths Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 55/69] libceph: fix return value check in alloc_msg_with_page_vector() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 65/69] hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 59/69] power: supply: max17042_battery: fix model download bug. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 67/69] mm/kasan: dont reduce quarantine in atomic contexts Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 44/69] MIPS: Fix pre-r6 emulation FPU initialisation Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 48/69] MIPS: Avoid a BUG warning during prctl(PR_SET_FP_MODE, ...) Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 58/69] power_supply: tps65217-charger: fix missing platform_set_drvdata() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 37/69] nl80211: validate number of probe response CSA counters Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 07/69] ocfs2: fix start offset to ocfs2_zero_range_for_truncate() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 35/69] net: can: ifi: Configure transmitter delay Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 42/69] i2c: mux: pca954x: retry updating the mux selection on failure Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 63/69] soc/tegra: pmc: Dont probe PMC if early initialisation fails Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:20 +0200
  [PATCH 4.7 25/69] mtd: pmcmsp-flash: Allocating too much in init_msp_flash() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 36/69] iwlwifi: mvm: update TX queue before making a copy of the skb Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 22/69] configfs: Return -EFBIG from configfs_write_bin_file. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 26/69] mtd: spi-nor: fix wrong "fully unlocked" test Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 31/69] fix memory leaks in tracing_buffers_splice_read() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 20/69] KEYS: Fix skcipher IV clobbering Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 16/69] fanotify: fix list corruption in fanotify_get_response() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 30/69] mac80211: reject TSPEC TIDs (TSIDs) for aggregation Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 18/69] cgroup: duplicate cgroup reference when cloning sockets Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 19/69] fix fault_in_multipages_...() on architectures with no-op access_ok() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 17/69] mm: memcontrol: make per-cpu charge cache IRQ-safe for socket accounting Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 15/69] fsnotify: add a way to stop queueing events on group shutdown Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 33/69] mm: delete unnecessary and unsafe init_tlb_ubc() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 08/69] Revert "ocfs2: bump up o2cb network protocol version" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 28/69] rtc: ds1307: Fix relying on reset value for weekday Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 14/69] mm: fix the page_swap_info() BUG_ON check Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 39/69] x86/efi: Only map RAM into EFI page tables if in mixed-mode Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 24/69] mtd: maps: sa1100-flash: potential NULL dereference Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 50/69] MIPS: paravirt: Fix undefined reference to smp_bootstrap Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 54/69] ceph: Correctly return NXIO errors from ceph_llseek Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 21/69] arm64: Call numa_store_cpu_info() earlier. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:30 +0200
  [PATCH 4.7 04/69] crypto: skcipher - Fix blkcipher walk OOM crash Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-28 11:40 +0200
  Re: [PATCH 4.7 00/69] 4.7.6-stable review Shuah Khan <shuah.kh@samsung.com> - 2016-09-28 18:50 +0200
    Re: [PATCH 4.7 00/69] 4.7.6-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-29 11:10 +0200
  Re: [PATCH 4.7 00/69] 4.7.6-stable review Guenter Roeck <linux@roeck-us.net> - 2016-09-29 00:50 +0200
    Re: [PATCH 4.7 00/69] 4.7.6-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-29 11:10 +0200
  Re: [PATCH 4.7 00/69] 4.7.6-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-29 10:40 +0200
    Re: [PATCH 4.7 00/69] 4.7.6-stable review Kevin Hilman <khilman@baylibre.com> - 2016-09-29 16:50 +0200
      Re: [PATCH 4.7 00/69] 4.7.6-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-29 17:30 +0200

csiph-web