Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1492312

Re: [PATCH 2/3] regulator: max77693: Also manipulate the fast charge current

Show all headers | View raw

On 09/27/2016 07:51 PM, Wolfgang Wiedmeyer wrote:
> 
> Mark Brown writes:
> 
>> On Tue, Sep 27, 2016 at 03:50:42PM +0200, Wolfgang Wiedmeyer wrote:
>>
>>> When charging is disabled (e.g. by removing the USB cable) the charge
>>> current is not reset to zero. So if I expose the current by the
>>> CURRENT_NOW property, it incorrectly reports the current that was set
>>> when charging was enabled, although there is no charging going on
>>> anymore. So I felt the need to update the charge current every time the
>>> charger gets enabled or disabled.
>>> Initially, the charge current is set to zero, so I think it needs to be
>>> set at least at the beginning to enable charging.
>>
>> Are you sure that the register value you're looking at is the actual
>> charge current right now and not just the maximum that the charger will
>> try to use depending on the conditions (supply available, battery
>> state...)?  It seems like you're acting as though it's the latter but
>> that's not what the chip is doing.
> 
> I was looking at the vendor code that was released for the Galaxy S3 and
> there the same register gets accessed for getting the current for
> the CURRENT_NOW property [1] and for setting the current [2]. So is this
> probably the wrong use of the CURRENT_NOW property because not the
> actual charge current is read but the maximum value that was
> set?

Yes, reading from this register will give only information about
currently set charge current. Not the real current.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] max77693: USB event listener for charger Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> - 2016-09-27 01:40 +0200
  [PATCH 3/3] power_supply: max77693: Listen for cable events and enable charging Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> - 2016-09-27 01:40 +0200
    Re: [PATCH 3/3] power_supply: max77693: Listen for cable events and  enable charging Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-27 10:20 +0200
      Re: [PATCH 3/3] power_supply: max77693: Listen for cable events and enable charging Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> - 2016-09-27 15:40 +0200
        Re: [PATCH 3/3] power_supply: max77693: Listen for cable events and  enable charging Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-28 10:00 +0200
  [PATCH 2/3] regulator: max77693: Also manipulate the fast charge current Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> - 2016-09-27 01:40 +0200
    Re: [PATCH 2/3] regulator: max77693: Also manipulate the fast charge  current Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-27 10:10 +0200
      Re: [PATCH 2/3] regulator: max77693: Also manipulate the fast charge current Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> - 2016-09-27 16:00 +0200
        Re: [PATCH 2/3] regulator: max77693: Also manipulate the fast charge  current Mark Brown <broonie@kernel.org> - 2016-09-27 18:20 +0200
          Re: [PATCH 2/3] regulator: max77693: Also manipulate the fast charge current Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> - 2016-09-27 20:00 +0200
            Re: [PATCH 2/3] regulator: max77693: Also manipulate the fast charge  current Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-28 10:10 +0200

csiph-web