Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC
Date	2016-09-28 09:00 +0200
Message-ID	<smh0u-3mN-15@gated-at.bofh.it> (permalink)
References	<sm21s-2jb-27@gated-at.bofh.it> <sm3Ae-3oW-27@gated-at.bofh.it> <sm3TA-3vI-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 27, 2016 at 09:51:35AM -0700, Vineet Gupta wrote:
> On 09/27/2016 09:37 AM, Kim Phillips wrote:
> > On Tue, 27 Sep 2016 07:53:56 -0700
> > Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> > 
> >> > This doesn't seem to be used anywhere
> > I thought so too, until I got this response for an equivalent patch:
> > 
> > https://lkml.org/lkml/2016/8/31/53
> 
> So this is some sort of "developer shortcut" to quickly enable 2 options with one
> option. Purpose seems dubious to me ! It would still be possible to enable vmalloc
> backed mmap on x86 by simply enabling that option from Kconfig.

PERF_USE_VMALLOC is not a user selectable option. Also
DEBUG_PERF_USE_VMALLOC clearly indicates its a _DEBUG_ option. Heck,
even the help text says what its for.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-27 17:00 +0200
  Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC Kim Phillips <kim.phillips@arm.com> - 2016-09-27 18:40 +0200
    Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-27 19:00 +0200
      Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC Peter Zijlstra <peterz@infradead.org> - 2016-09-28 09:00 +0200

csiph-web