RE: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

From	Kiwoong Kim <kwmad.kim@samsung.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR
Date	2016-09-28 07:40 +0200
Message-ID	<smfL3-2Hc-1@gated-at.bofh.it> (permalink)
References	<s9ZiF-7DA-9@gated-at.bofh.it> <sm9cC-6Wf-27@gated-at.bofh.it> <smfL3-2Hc-3@gated-at.bofh.it> <smfrH-2AU-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Martin.

I think that the patch is correct.
UFS spec says "The Data Segment area is empty" for Read Descriptor.
I have been using similar code with it and it works.
That have been already applied in Android kernel.

Reviewed-by: Kiwoong Kim <kwmad.kim@samsung.com>

Regards.

> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> owner@vger.kernel.org] On Behalf Of Martin K. Petersen
> Sent: Wednesday, September 28, 2016 2:14 PM
> To: subhashj@codeaurora.org
> Cc: Zang Leigang; vinholikatti@gmail.com; jejb@linux.vnet.ibm.com;
> martin.petersen@oracle.com; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-scsi-owner@vger.kernel.org
> Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR
> 
> >>>>> "Subhash" == subhashj  <subhashj@codeaurora.org> writes:
> 
> Subhash> Looks good to me.
> 
> > -	/* Data segment length */
> > -	ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD(
> > -			0, 0, len >> 8, (u8)len);
> > +	/* Data segment length only need for WRITE_DESC */
> > +	if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC)
> > +		ucd_req_ptr->header.dword_2 =
> > +			UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len);
> > +	else
> > +		ucd_req_ptr->header.dword_2 = 0;
> 
> What about READ_DESC?
> 
> --
> Martin K. Petersen	Oracle Linux Engineering
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

Thread

Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR subhashj@codeaurora.org - 2016-09-28 00:40 +0200
  Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-28 07:20 +0200
    RE: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR Kiwoong Kim <kwmad.kim@samsung.com> - 2016-09-28 07:40 +0200
      Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-30 03:40 +0200
    Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR subhashj@codeaurora.org - 2016-09-29 00:50 +0200

csiph-web