Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1492246

Re: [PATCH v5] powerpc: Do not make the entire heap executable

Show all headers | View raw

On Wed, Sep 28, 2016 at 11:42:11AM +1000, Michael Ellerman wrote:

> But this is not really a powerpc patch, and I'm not an ELF expert. So
> I'm not comfortable merging it via the powerpc tree. It doesn't look
> like we really have a maintainer for binfmt_elf.c, so I'm not sure who
> should be acking that part.

Thanks a bunch for looking at this Michael.

> I've added Al Viro to Cc, he maintains fs/ and might be interested.

> I've also added Andrew Morton who might be happy to put this in his
> tree, and see if anyone complains?

For those added to the CC, I would re-state my original commit message
more clearly.

My research showed that the ELF loader bug fixed in this patch is the
root cause bug fix required to implement this hunk:

> > -#define VM_DATA_DEFAULT_FLAGS32	(VM_READ | VM_WRITE | VM_EXEC | \
> > +#define VM_DATA_DEFAULT_FLAGS32 \
> > +	(((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0) | \
> > +				 VM_READ | VM_WRITE | \
> >  				 VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)

Eg that 32 bit powerpc currently unconditionally injects writable,
executable pages into a user space process.

This critically undermines all the W^X security work that has been
done in the tool chain and user space by the PPC community.

I would encourage people to view this as an important security patch
for 32 bit powerpc environments.

Regards,
Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5] powerpc: Do not make the entire heap executable Michael Ellerman <mpe@ellerman.id.au> - 2016-09-28 03:50 +0200
  Re: [PATCH v5] powerpc: Do not make the entire heap executable Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-09-28 05:00 +0200
    Re: [PATCH v5] powerpc: Do not make the entire heap executable Florian Weimer <fw@deneb.enyo.de> - 2016-09-28 15:20 +0200
  Re: [PATCH v5] powerpc: Do not make the entire heap executable Kees Cook <keescook@chromium.org> - 2016-09-28 19:20 +0200
    Re: [PATCH v5] powerpc: Do not make the entire heap executable Oleg Nesterov <oleg@redhat.com> - 2016-09-29 18:10 +0200

csiph-web