Re: [PATCH 1/3] arm64: dump: Make ptdump debugfs a separate option

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] arm64: dump: Make ptdump debugfs a separate option
Date	2016-09-30 02:50 +0200
Message-ID	<smUbv-35g-3@gated-at.bofh.it> (permalink)
References	<smRdD-15L-9@gated-at.bofh.it> <smRdE-15L-13@gated-at.bofh.it> <smTS9-2YG-1@gated-at.bofh.it> <smU1Q-31V-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 29, 2016 at 05:31:09PM -0700, Laura Abbott wrote:
> On 09/29/2016 05:13 PM, Mark Rutland wrote:
> >On Thu, Sep 29, 2016 at 02:32:55PM -0700, Laura Abbott wrote:
> >>+int ptdump_register(struct ptdump_info *info, const char *name)
> >>+{
> >>+	ptdump_initialize(info);
> >>+	return ptdump_debugfs_create(info, name);
> >> }
> >
> >It feels like a layering violation to have the core ptdump code call the
> >debugfs ptdump code. Is there some reason this has to live here?
> 
> Which 'this' are you referring to here? Are you suggesting moving
> the ptdump_register elsewhere or moving the debugfs create elsewhere?

Sorry, I should have worded that better.

I meant moving ptdump_register into ptdump_debugfs.c, perhaps renamed to make it
clear it's debugfs-specific.

We could instead update existing users to call ptdump_debugfs_create()
directly, and have that call ptdump_initialize(), which could itself become a
staic inline in a header.

Thanks,
Mark.

Thread

[PATCH 0/3] WX Checking for arm64 Laura Abbott <labbott@redhat.com> - 2016-09-29 23:40 +0200
  [PATCH 3/3] arm64: dump: Add checking for writable and exectuable pages Laura Abbott <labbott@redhat.com> - 2016-09-29 23:40 +0200
    Re: [PATCH 3/3] arm64: dump: Add checking for writable and  exectuable pages Mark Rutland <mark.rutland@arm.com> - 2016-09-30 04:10 +0200
    Re: [PATCH 3/3] arm64: dump: Add checking for writable and  exectuable pages Mark Rutland <mark.rutland@arm.com> - 2016-09-30 18:00 +0200
      Re: [PATCH 3/3] arm64: dump: Add checking for writable and exectuable pages Kees Cook <keescook@chromium.org> - 2016-09-30 18:30 +0200
        Re: [PATCH 3/3] arm64: dump: Add checking for writable and  exectuable pages Mark Rutland <mark.rutland@arm.com> - 2016-09-30 18:50 +0200
          Re: [PATCH 3/3] arm64: dump: Add checking for writable and exectuable pages Kees Cook <keescook@chromium.org> - 2016-09-30 19:20 +0200
  [PATCH 2/3] arm64: dump: Make the page table dumping seq_file optional Laura Abbott <labbott@redhat.com> - 2016-09-29 23:40 +0200
    Re: [PATCH 2/3] arm64: dump: Make the page table dumping seq_file  optional Mark Rutland <mark.rutland@arm.com> - 2016-09-30 02:40 +0200
  [PATCH 1/3] arm64: dump: Make ptdump debugfs a separate option Laura Abbott <labbott@redhat.com> - 2016-09-29 23:40 +0200
    Re: [PATCH 1/3] arm64: dump: Make ptdump debugfs a separate option Mark Rutland <mark.rutland@arm.com> - 2016-09-30 02:30 +0200
      Re: [PATCH 1/3] arm64: dump: Make ptdump debugfs a separate option Laura Abbott <labbott@redhat.com> - 2016-09-30 02:40 +0200
        Re: [PATCH 1/3] arm64: dump: Make ptdump debugfs a separate option Mark Rutland <mark.rutland@arm.com> - 2016-09-30 02:50 +0200
          Re: [PATCH 1/3] arm64: dump: Make ptdump debugfs a separate option Laura Abbott <labbott@redhat.com> - 2016-09-30 03:20 +0200
            Re: [PATCH 1/3] arm64: dump: Make ptdump debugfs a separate option Mark Rutland <mark.rutland@arm.com> - 2016-09-30 03:30 +0200
  Re: [kernel-hardening] [PATCH 0/3] WX Checking for arm64 Kees Cook <keescook@chromium.org> - 2016-09-30 03:30 +0200

csiph-web