Re: [PATCH 17/26] intel_telemetry_debugfs: constify local structures

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 17/26] intel_telemetry_debugfs: constify local structures
Date	2016-09-30 02:10 +0200
Message-ID	<smTyN-2OB-11@gated-at.bofh.it> (permalink)
References	<sgcZz-6F5-5@gated-at.bofh.it> <sgd9g-6Ig-31@gated-at.bofh.it> <smwVz-4Z7-3@gated-at.bofh.it> <smBVf-8e7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 29, 2016 at 07:19:21AM +0200, Julia Lawall wrote:
> 
> 
> On Wed, 28 Sep 2016, Darren Hart wrote:
> 
> > On Sun, Sep 11, 2016 at 03:05:59PM +0200, Julia Lawall wrote:
> >
> > Hi Julia,
> >
> > > For structure types defined in the same file or local header files, find
> > > top-level static structure declarations that have the following
> > > properties:
> > > 1. Never reassigned.
> > > 2. Address never taken
> >
> > Hrm. telem_apl_debugfs_conf is passed to the TELEM_DEBUGFS_CPU macro as the
> > second argument "data":
> >
> > #define TELEM_DEBUGFS_CPU(model, data) \
> > 	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
> >
> > And the address is taken, and later assigned to the debugfs_conf pointer.
> >
> > The usage still seems OK, but did I misunderstand the conditions?
> 
> OK, this is definitely a weakness of the script and my methodology for
> checking the results.  There was already a case of a cast that I have
> fixed up my script for, but this one is worse because it's under a macro.
> I can look into whether the cast can be changed to add a const, but for
> the time being, I think you should just drop this patch.
> 

Done! :-)

> Thanks for the careful review.
> 

Sure thing, thanks for all your work with cocci.
-- 
Darren Hart
Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 17/26] intel_telemetry_debugfs: constify local structures Darren Hart <dvhart@infradead.org> - 2016-09-29 02:00 +0200
  Re: [PATCH 17/26] intel_telemetry_debugfs: constify local  structures Julia Lawall <julia.lawall@lip6.fr> - 2016-09-29 07:20 +0200
    Re: [PATCH 17/26] intel_telemetry_debugfs: constify local structures Darren Hart <dvhart@infradead.org> - 2016-09-30 02:10 +0200

csiph-web