Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash()

From	Paul Bolle <pebolle@tiscali.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash()
Date	2016-09-29 23:20 +0200
Message-ID	<smQUh-Ze-3@gated-at.bofh.it> (permalink)
References	(7 earlier) <smL8d-5IG-13@gated-at.bofh.it> <smPvb-8lN-9@gated-at.bofh.it> <smQ7T-qR-5@gated-at.bofh.it> <smQrg-xo-7@gated-at.bofh.it> <smQAV-AR-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-09-29 at 13:56 -0700, Joe Perches wrote:
> It doesn't matter match either way to me.
> 
> The case for the unnecessary multiply with <= gcc 4.8 was
> removed with:
> 
> commit 91c6a05f72a996bee5133e76374ab3ad7d3b9b72
> Author: Alexey Dobriyan <adobriyan@gmail.com>
> Date:   Tue Jul 26 15:22:08 2016 -0700
> 
>     mm: faster kmalloc_array(), kcalloc()
>     
>     When both arguments to kmalloc_array() or kcalloc() are known at compile
>     time then their product is known at compile time but search for kmalloc
>     cache happens at runtime not at compile time.
>     
>     Link: http://lkml.kernel.org/r/20160627213454.GA2440@p183.telecom.by
>     Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>     Cc: Christoph Lameter <cl@linux.com>
>     Cc: Pekka Enberg <penberg@kernel.org>
>     Cc: David Rientjes <rientjes@google.com>
>     Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

You've lost me.

Why does this stop you fixing an apparently wrong checkpatch rule,
crude as parts of it are (ie, uppercase identifier must be a constant)?


Paul Bolle

Thread

[PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-29 11:10 +0200
  Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Paul Bolle <pebolle@tiscali.nl> - 2016-09-29 12:00 +0200
    Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Joe Perches <joe@perches.com> - 2016-09-29 12:10 +0200
      Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Paul Bolle <pebolle@tiscali.nl> - 2016-09-29 13:20 +0200
        Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Paul Bolle <pebolle@tiscali.nl> - 2016-09-29 13:50 +0200
          Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Joe Perches <joe@perches.com> - 2016-09-29 17:10 +0200
            Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Paul Bolle <pebolle@tiscali.nl> - 2016-09-29 21:50 +0200
              Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Joe Perches <joe@perches.com> - 2016-09-29 22:30 +0200
                Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Paul Bolle <pebolle@tiscali.nl> - 2016-09-29 22:50 +0200
                Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Joe Perches <joe@perches.com> - 2016-09-29 23:00 +0200
                Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Paul Bolle <pebolle@tiscali.nl> - 2016-09-29 23:20 +0200
                Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Joe Perches <joe@perches.com> - 2016-09-29 23:30 +0200
                Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in  init_origin_hash() Paul Bolle <pebolle@tiscali.nl> - 2016-09-29 23:50 +0200
                Re: dm snapshot: Use kmalloc_array() in init_origin_hash() ? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-30 09:20 +0200
    Re: dm snapshot: Use kmalloc_array() in init_origin_hash() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-29 13:50 +0200
      Re: dm snapshot: Use kmalloc_array() in init_origin_hash() Theodore Ts'o <tytso@mit.edu> - 2016-09-29 15:10 +0200

csiph-web