Re: [PATCH v19 05/12] fpga-mgr: add fpga image information struct

From	Alan Tull <delicious.quinoa@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v19 05/12] fpga-mgr: add fpga image information struct
Date	2016-09-29 06:40 +0200
Message-ID	<smBix-7LA-5@gated-at.bofh.it> (permalink)
References	<smwLU-4W8-7@gated-at.bofh.it> <smwLU-4W8-9@gated-at.bofh.it> <smwLU-4W8-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 28, 2016 at 6:41 PM, Moritz Fischer
<moritz.fischer@ettus.com> wrote:
Hi Moritz,

> Hi Alan,
>
> generally ok with the change.

Cool!

>
> On Wed, Sep 28, 2016 at 11:21 AM, Alan Tull <atull@opensource.altera.com> wrote:
>
>> -int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf,
>> -                     size_t count)
>> +int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info *info,
>> +                     const char *buf, size_t count)
>
> Doesn't this break the both socfpga and zynq if [6/12] and [7/12] are
> not part of this commit?
> i.e shouldn't 5,6 and 7 be a single commit?

Yeah, squashing those would improve bisectability.

Alan
aka atull

>
> Cheers,
> Moritz

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v19 05/12] fpga-mgr: add fpga image information struct Moritz Fischer <moritz.fischer@ettus.com> - 2016-09-29 01:50 +0200
  Re: [PATCH v19 05/12] fpga-mgr: add fpga image information struct Alan Tull <delicious.quinoa@gmail.com> - 2016-09-29 06:40 +0200

csiph-web