Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1493135

Re: [PATCH 2/3] DT: EVM: add LEDs

From Rob Herring <robh+dt@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] DT: EVM: add LEDs
Date 2016-09-29 07:20 +0200
Message-ID <smBVf-8e7-1@gated-at.bofh.it> (permalink)
References <slT7P-5um-3@gated-at.bofh.it> <slT7V-5um-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Sep 27, 2016 at 12:26 AM, H. Nikolaus Schaller
<hns@goldelico.com> wrote:

The subject gives no indication this is for OMAP. Please follow
standard patterns.

> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index be659e8..19f5f0a 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -17,6 +17,66 @@
>                 device_type = "memory";
>                 reg = <0x80000000 0x7F000000>; /* 2032 MB */
>         };
> +
> +       evm_leds {
> +               compatible = "gpio-leds";
> +
> +               led@1 {

Drop the unit address. There's no reg property.

> +                       label = "omap5:red:led";
> +                       gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "mmc0";
> +                       default-state = "off";
> +               };
> +
> +               led@2 {
> +                       label = "omap5:green:led";
> +                       gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "mmc1";
> +                       default-state = "off";
> +               };
> +
> +               led@3 {
> +                       label = "omap5:blue:led";
> +                       gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "mmc2";
> +                       default-state = "off";
> +               };
> +
> +               led@4 {
> +                       label = "omap5:green:led1";
> +                       gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "default-on";
> +                       default-state = "off";
> +               };
> +
> +               led@5 {
> +                       label = "omap5:green:led2";
> +                       gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "default-on";
> +                       default-state = "off";
> +               };
> +
> +               led@6 {
> +                       label = "omap5:green:led3";
> +                       gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "heartbeat";
> +                       default-state = "off";
> +               };
> +
> +               led@7 {
> +                       label = "omap5:green:led4";
> +                       gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "heartbeat";
> +                       default-state = "off";
> +               };
> +
> +               led@8 {
> +                       label = "omap5:green:led5";
> +                       gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "heartbeat";
> +                       default-state = "off";
> +               };
> +       };
>  };
>
>  &hdmi {
> --
> 2.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] DT: EVM: add LEDs "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-09-27 07:30 +0200
  Re: [PATCH 2/3] DT: EVM: add LEDs Tony Lindgren <tony@atomide.com> - 2016-09-27 21:50 +0200
    Re: [PATCH 2/3] DT: EVM: add LEDs "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-09-27 22:20 +0200
      Re: [PATCH 2/3] DT: EVM: add LEDs Tony Lindgren <tony@atomide.com> - 2016-09-28 05:40 +0200
        Re: [PATCH 2/3] DT: EVM: add LEDs "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-09-28 08:50 +0200
          Re: [PATCH 2/3] DT: EVM: add LEDs Tony Lindgren <tony@atomide.com> - 2016-09-28 17:20 +0200
            Re: [PATCH 2/3] DT: EVM: add LEDs "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-09-28 17:30 +0200
              Re: [PATCH 2/3] DT: EVM: add LEDs Tony Lindgren <tony@atomide.com> - 2016-09-28 18:20 +0200
  Re: [PATCH 2/3] DT: EVM: add LEDs Rob Herring <robh+dt@kernel.org> - 2016-09-29 07:20 +0200
    Re: [PATCH 2/3] DT: EVM: add LEDs "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-09-29 07:20 +0200
    Re: [PATCH 2/3] DT: EVM: add LEDs "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-09-29 07:30 +0200

csiph-web