Groups > linux.kernel > #1492062

Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

From	Sean Paul <seanpaul@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE
Date	2016-09-27 19:30 +0200
Message-ID	<sm4mB-3UT-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <sm2Xv-2S0-27@gated-at.bofh.it> <sm37c-3bm-17@gated-at.bofh.it> <sm3Ad-3oW-5@gated-at.bofh.it> <sm3JU-3si-47@gated-at.bofh.it> <sm3TA-3vI-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 27, 2016 at 12:54 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 27 September 2016 at 17:43, Joe Perches <joe@perches.com> wrote:
>> On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote:
>>> On 27 September 2016 at 17:04, Joe Perches <joe@perches.com> wrote:
>>> > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote:
>>> > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches <joe@perches.com> wrote:
>>> > > > Use a bit more consistent style with kernel loglevels
>>> > > I'm not convinced this is worth doing if we're going to keep the
>>> > > WARN/WARNING discrepancy, and I don't think we should switch DRM_WARN
>>> > > to DRM_WARNING since it's so widely used.
>>> > There is no DRM_WARN inconsistency.
>>> DRM_WARN is to DRM_WARNING like DRM_INFO is to DRM_INFORMATION and
>>> DRM_NOTE is to DRM_NOTICE...
>>
>> DRM_INFORMATION doesn't exist in the kernel tree.
>>
>>> is what I'm thinking and seemingly so
>>> does Sean. Fwiw that part seem cosmetic/unrelated to the rest of the
>>> patch, so it might be worth keeping separate ?
>>
>> To me, simplifying the macro means using the common kernel
>> macro forms.
>>
> "unify" might be better, but I agree.
>
> Either way there's no point in elaborating on the point me(Sean?)
> meant since it's just going to get shoot down like a dog ;-)

Yeah, I can see both sides, and I suppose I don't really care either
way. Given that DRM_NOTE/NOTICE is only used 7 places (in one file), I
doubt there are going to be any strong feelings.

Sean

>
> Regards,
> Emil

Thread

[PATCH 0/2] drm: Neaten and reduce object size Joe Perches <joe@perches.com> - 2016-09-26 04:20 +0200
  [PATCH 2/2] drm: Simplify drm_printk to reduce object size quite a bit Joe Perches <joe@perches.com> - 2016-09-26 04:20 +0200
    Re: [PATCH 2/2] drm: Simplify drm_printk to reduce object size quite  a bit Chris Wilson <chris@chris-wilson.co.uk> - 2016-09-26 10:40 +0200
      Re: [PATCH 2/2] drm: Simplify drm_printk to reduce object size quite  a bit Sean Paul <seanpaul@chromium.org> - 2016-09-27 18:00 +0200
        Re: [PATCH 2/2] drm: Simplify drm_printk to reduce object size quite  a bit Sean Paul <seanpaul@chromium.org> - 2016-09-29 15:40 +0200
  [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE Joe Perches <joe@perches.com> - 2016-09-26 04:20 +0200
    Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE Sean Paul <seanpaul@chromium.org> - 2016-09-27 18:00 +0200
      Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to  DRM_NOTICE Joe Perches <joe@perches.com> - 2016-09-27 18:10 +0200
        Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE Emil Velikov <emil.l.velikov@gmail.com> - 2016-09-27 18:40 +0200
          Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to  DRM_NOTICE Joe Perches <joe@perches.com> - 2016-09-27 18:50 +0200
            Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE Emil Velikov <emil.l.velikov@gmail.com> - 2016-09-27 19:00 +0200
              Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE Sean Paul <seanpaul@chromium.org> - 2016-09-27 19:30 +0200
          Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to  DRM_NOTICE Joe Perches <joe@perches.com> - 2016-09-27 19:00 +0200

csiph-web