Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491916

Re: [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show

Show all headers | View raw

From: Jia He <hejianet@gmail.com>
Date: Mon, 26 Sep 2016 16:09:10 +0800

> +static int snmp_seq_show_tcp_udp(struct seq_file *seq, void *v)
> +{
> +	int i;
> +	unsigned long buff[TCPUDP_MIB_MAX];
> +	struct net *net = seq->private;

Please always order local variables from longest to shortest
line.

Please audit your entire patch series for this problem.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/7] Reduce cache miss for snmp_fold_field Jia He <hejianet@gmail.com> - 2016-09-26 10:20 +0200
  [PATCH v4 3/7] proc: Reduce cache miss in snmp6_seq_show Jia He <hejianet@gmail.com> - 2016-09-26 10:20 +0200
  [PATCH v4 4/7] proc: Reduce cache miss in sctp_snmp_seq_show Jia He <hejianet@gmail.com> - 2016-09-26 10:20 +0200
  [PATCH v4 5/7] proc: Reduce cache miss in xfrm_statistics_seq_show Jia He <hejianet@gmail.com> - 2016-09-26 10:20 +0200
  [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show Jia He <hejianet@gmail.com> - 2016-09-26 10:20 +0200
    Re: [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show David Miller <davem@davemloft.net> - 2016-09-27 15:50 +0200
  [PATCH v4 1/7] net:snmp: Introduce generic interfaces for snmp_get_cpu_field{,64} Jia He <hejianet@gmail.com> - 2016-09-26 10:20 +0200
  [PATCH v4 7/7] net: Suppress the "Comparison to NULL could be written" warnings Jia He <hejianet@gmail.com> - 2016-09-26 10:20 +0200

csiph-web