Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1491054
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Staging: android: fixed permissions style issue |
| Date | 2016-09-26 05:10 +0200 |
| Message-ID | <slusN-6NA-1@gated-at.bofh.it> (permalink) |
| References | <slu9r-6r0-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote: > Fixed a coding style issue. Changed symbolic permissions to octal. If you do these, please shorten the lines where possible. > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c [] > @@ -204,10 +204,10 @@ device_initcall(lowmem_init); > * not really modular, but the easiest way to keep compat with existing > * bootargs behaviour is to continue using module_param here. > */ > -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); > +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); > module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, > - S_IRUGO | S_IWUSR); > + 0644); module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644); etc...
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Staging: android: fixed permissions style issue Eric Salem <ericsalem@gmail.com> - 2016-09-26 04:50 +0200
Re: [PATCH] Staging: android: fixed permissions style issue Joe Perches <joe@perches.com> - 2016-09-26 05:10 +0200
[PATCH v2] Staging: android: fixed permissions style issue Eric Salem <ericsalem@gmail.com> - 2016-09-26 05:40 +0200
csiph-web