Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490886

Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces
Date 2016-09-25 14:50 +0200
Message-ID <slh2x-6EB-11@gated-at.bofh.it> (permalink)
References <slfDr-5Uj-5@gated-at.bofh.it> <slfDr-5Uj-7@gated-at.bofh.it> <slfDr-5Uj-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

>> @@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg)
>>          if (debugmode)
>>              printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x (%s) cipmask=0x%x\n",
>>                     card->contrnr, cmsg->Info, capi_info2str(cmsg->Info), card->cipmask);
>> -        if (cmsg->Info) {
>> +        if (cmsg->Info)
>>              listen_change_state(card, EV_LISTEN_CONF_ERROR);
>> -        } else if (card->cipmask == 0) {
>> +        else if (card->cipmask == 0)
>>              listen_change_state(card, EV_LISTEN_CONF_EMPTY);
>> -        } else {
>> +             else
> 
>    Indented too much.

How do you think about an alignment of this "else"
with the corresponding if statement three lines above?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-25 13:20 +0200
  Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-25 14:50 +0200
    Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces Paul Bolle <pebolle@tiscali.nl> - 2016-09-26 11:30 +0200
      Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-26 15:00 +0200
        Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces Paul Bolle <pebolle@tiscali.nl> - 2016-09-26 22:00 +0200

csiph-web