[PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors

From	Noralf Trønnes <noralf@tronnes.org>
Newsgroups	linux.kernel
Subject	[PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors
Date	2016-09-27 14:00 +0200
Message-ID	<slZdf-D0-7@gated-at.bofh.it> (permalink)
References	<slZdf-D0-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Writing to an AT24C32 generates on average 2x i2c transfer errors per
32-byte page write. Which amounts to a lot for a 4k write. This is due
to the fact that the chip doesn't respond during it's internal write
cycle when the at24 driver tries and retries the next write.
Reduce this flooding of the log by using dev_err_ratelimited().

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
---
 drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index df036ed..370a322 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -207,7 +207,8 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev,
 	    (msg->flags & I2C_M_IGNORE_NAK))
 		return 0;
 
-	dev_err(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err);
+	dev_err_ratelimited(i2c_dev->dev, "i2c transfer failed: %x\n",
+			    i2c_dev->msg_err);
 
 	if (i2c_dev->msg_err & BCM2835_I2C_S_ERR)
 		return -EREMOTEIO;
-- 
2.8.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors Noralf Trønnes <noralf@tronnes.org> - 2016-09-27 14:00 +0200
  Re: [PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors Martin Sperl <kernel@martin.sperl.org> - 2016-09-27 15:10 +0200
    Re: [PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer  errors Noralf Trønnes <noralf@tronnes.org> - 2016-09-27 21:30 +0200

csiph-web