Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491765

Re: [PATCH] fs/select: add vmalloc fallback for select(2)

Show all headers | View raw

On 09/23/2016 06:47 PM, Jason Baron wrote:
> Hi,
>
> On 09/23/2016 03:24 AM, Nicholas Piggin wrote:
>> On Fri, 23 Sep 2016 14:42:53 +0800
>> "Hillf Danton" <hillf.zj@alibaba-inc.com> wrote:
>>
>>>>
>>>> The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows
>>>> with the number of fds passed. We had a customer report page allocation
>>>> failures of order-4 for this allocation. This is a costly order, so it might
>>>> easily fail, as the VM expects such allocation to have a lower-order fallback.
>>>>
>>>> Such trivial fallback is vmalloc(), as the memory doesn't have to be
>>>> physically contiguous. Also the allocation is temporary for the duration of the
>>>> syscall, so it's unlikely to stress vmalloc too much.
>>>>
>>>> Note that the poll(2) syscall seems to use a linked list of order-0 pages, so
>>>> it doesn't need this kind of fallback.
>>
>> How about something like this? (untested)

This pushes the limit further, but might just delay the problem. Could be an 
optimization on top if there's enough interest, though.

[...]

>> +
>> +		if (!(fds.in && fds.out && fds.ex &&
>> +				fds.res_in && fds.res_out && fds.res_ex))
>> +			goto out;
>> +	} else {
>> +		if (nr_bytes > sizeof(stack_fds)) {
>> +			/* Not enough space in on-stack array */
>> +			if (nr_bytes > PAGE_SIZE * 2)
>
> The 'if' looks extraneous?
>
> Also, I wonder if we can just avoid some allocations altogether by
> checking by if the user fd_set pointers are NULL? That can avoid failures :)

That would be a more major rewrite, as the core algorithm doesn't expect NULLs.

> Thanks,
>
> -Jason
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] fs/select: add vmalloc fallback for select(2) Jason Baron <jbaron@akamai.com> - 2016-09-23 18:50 +0200
  Re: [PATCH] fs/select: add vmalloc fallback for select(2) Vlastimil Babka <vbabka@suse.cz> - 2016-09-27 10:50 +0200
    Re: [PATCH] fs/select: add vmalloc fallback for select(2) Nicholas Piggin <npiggin@gmail.com> - 2016-09-27 13:30 +0200
      RE: [PATCH] fs/select: add vmalloc fallback for select(2) David Laight <David.Laight@ACULAB.COM> - 2016-09-27 13:50 +0200
        Re: [PATCH] fs/select: add vmalloc fallback for select(2) Nicholas Piggin <npiggin@gmail.com> - 2016-09-27 13:50 +0200
          Re: [PATCH] fs/select: add vmalloc fallback for select(2) Vlastimil Babka <vbabka@suse.cz> - 2016-09-27 14:00 +0200
            RE: [PATCH] fs/select: add vmalloc fallback for select(2) David Laight <David.Laight@ACULAB.COM> - 2016-09-28 18:40 +0200
              Re: [PATCH] fs/select: add vmalloc fallback for select(2) Vlastimil Babka <vbabka@suse.cz> - 2016-09-28 22:10 +0200

csiph-web