Re: [PATCH] simplefb: Disable and release clocks and regulators in destroy callback

From	Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] simplefb: Disable and release clocks and regulators in destroy callback
Date	2016-09-27 10:30 +0200
Message-ID	<slVW1-7ay-3@gated-at.bofh.it> (permalink)
References	<seH1L-6cX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 07/09/16 12:09, Chen-Yu Tsai wrote:
> simplefb gets unregister when a proper framebuffer driver comes in and
> kicks it out. However the claimed clocks and regulators stay enabled
> as they are only released in the platform device remove function, which
> in theory would never get called.
> 
> Move the clock/regulator cleanup into the framebuffer destroy callback,
> which gets called as part of the framebuffer unregister process.
> 
> Note this introduces asymmetry in how the resources are claimed and
> released.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/video/fbdev/simplefb.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Thanks, queued for 4.9.

 Tomi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] simplefb: Disable and release clocks and regulators in  destroy callback Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-09-27 10:30 +0200

csiph-web