Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1491753

Re: [PATCH 04/26] matroxfb: constify local structures

From Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH 04/26] matroxfb: constify local structures
Date 2016-09-27 10:20 +0200
Message-ID <slVMl-77s-13@gated-at.bofh.it> (permalink)
References <sgcZz-6F5-5@gated-at.bofh.it> <sgd9g-6Ig-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On 11/09/16 16:05, Julia Lawall wrote:
> For structure types defined in the same file or local header files, find
> top-level static structure declarations that have the following
> properties:
> 1. Never reassigned.
> 2. Address never taken
> 3. Not passed to a top-level macro call
> 4. No pointer or array-typed field passed to a function or stored in a
> variable.
> Declare structures having all of these properties as const.
> 
> Done using Coccinelle.
> Based on a suggestion by Joe Perches <joe@perches.com>.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
> The semantic patch seems too long for a commit log, but is in the cover
> letter.
> 
>  drivers/video/fbdev/matrox/matroxfb_g450.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, queued for 4.9.

 Tomi


Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 04/26] matroxfb: constify local structures Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-09-27 10:20 +0200

csiph-web