Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

From	khalasa@piap.pl (Krzysztof Hałasa)
Newsgroups	linux.kernel
Subject	Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)
Date	2016-09-27 07:30 +0200
Message-ID	<slT7V-5um-13@gated-at.bofh.it> (permalink)
References	(3 earlier) <sjQ4q-1aG-23@gated-at.bofh.it> <sk81j-45n-1@gated-at.bofh.it> <ske6J-86C-21@gated-at.bofh.it> <slwNX-88R-3@gated-at.bofh.it> <slAeR-20r-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andrey Utkin <andrey_utkin@fastmail.com> writes:

>> Does (only) adding the
>> 
>> 	pci_read_config_word(solo_dev->pdev, PCI_STATUS, &val);
>> 
>> in solo_reg_write() help?
>
> Yes.
> I have posted a patch with this change few days ago, I thought you have
> noticed it.

Well, I think you haven't sent me a copy. Anyway, it would be great to
determine where exactly writes need a flush. Adding it everywhere is a
bit suboptimal, one would think.

Can you share some details about the machine you are experiencing the
problems on? CPU, chipset? I'd try to see if I can recreate the problem.

Alternatively, you could investigate yourself - at first you could put
pci_read_config_word() at the end of subroutines (including return
statements) using solo_reg_write(). And in that solo_p2m_dma_desc(),
before wait_for_completion_timeout(). Then eliminate them using some
sort of binary search to see which ones are required.
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

Thread

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) khalasa@piap.pl (Krzysztof Hałasa) - 2016-09-26 07:40 +0200
  Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-26 11:20 +0200
    Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) khalasa@piap.pl (Krzysztof Hałasa) - 2016-09-27 07:30 +0200
      Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-27 09:50 +0200
        Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) khalasa@piap.pl (Krzysztof Hałasa) - 2016-09-27 13:40 +0200
          Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-27 16:30 +0200
            Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) khalasa@piap.pl (Krzysztof Hałasa) - 2016-09-28 07:30 +0200

csiph-web