Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1491640

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)

From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)
Date 2016-09-27 03:40 +0200
Message-ID <slPxf-34m-3@gated-at.bofh.it> (permalink)
References <skfma-lq-23@gated-at.bofh.it> <slO89-2cZ-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 2016-09-26 at 17:01 -0700, Andrew Morton wrote:

> I don't share Eric's concerns about performance here.  If the vmalloc()
> is called, we're about to write to that quite large amount of memory
> which we just allocated, and the vmalloc() overhead will be relatively
> low.

I did not care of the performance of this particular select() system
call really, but other cpus because of more TLB invalidations.

At least CONFIG_DEBUG_PAGEALLOC=y builds should be impacted, but maybe
we do not care.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2) Andrew Morton <akpm@linux-foundation.org> - 2016-09-27 02:10 +0200
  Re: [PATCH v2] fs/select: add vmalloc fallback for select(2) Eric Dumazet <eric.dumazet@gmail.com> - 2016-09-27 03:40 +0200
    Re: [PATCH v2] fs/select: add vmalloc fallback for select(2) Vlastimil Babka <vbabka@suse.cz> - 2016-09-27 10:20 +0200
      Re: [PATCH v2] fs/select: add vmalloc fallback for select(2) Eric Dumazet <eric.dumazet@gmail.com> - 2016-09-27 15:40 +0200
  Re: [PATCH v2] fs/select: add vmalloc fallback for select(2) Vlastimil Babka <vbabka@suse.cz> - 2016-09-27 10:10 +0200

csiph-web