Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1491615

Re: [PATCH] elevator: remove second argument in elevator_init()

From Alexey Klimov <klimov.linux@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] elevator: remove second argument in elevator_init()
Date 2016-09-27 02:20 +0200
Message-ID <slOhP-2ju-11@gated-at.bofh.it> (permalink)
References <qR1Gy-7or-11@gated-at.bofh.it> <qVFvJ-1dk-51@gated-at.bofh.it> <rixSp-4h4-7@gated-at.bofh.it> <riyOt-4Zm-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Mar 31, 2016 at 1:34 AM, Jens Axboe <axboe@kernel.dk> wrote:
> On 03/30/2016 05:31 PM, Alexey Klimov wrote:
>>
>> Hi all,
>>
>> On Wed, Jan 27, 2016 at 9:01 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
>>>
>>> Alexey Klimov <klimov.linux@gmail.com> writes:
>>>
>>>> Last user of elevator_init() with non-NULL name as second argument
>>>> that supposed to be s390 dasd driver has gone few releases ago.
>>>> Drivers rely on elevator_change(), elevator_switch() and friends
>>>> for example. Right now elevator_init() is always called as
>>>> elevator_init(q, NULL).
>>>>
>>>> Patch removes passing of second name argument and its usage.
>>>>
>>>> While we're at it fix following if-check after removed lines. We know
>>>> that elevator_type e is initialized by NULL and need to check only
>>>> chosen_elevator.
>>>>
>>>> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
>>>
>>>
>>> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
>>
>>
>>
>> what is the status of this patch? Is it that wrong and are there some
>> concerns or do I need to resend it?
>
>
> It looks fine, I'll pick it up for 4.7.
>
> --
> Jens Axboe


So, I guess this one was lost: I can't find it in the tree.
Looks like the easiest way will be to rebase (and check that it's
still fine) and resend. Right?

Best regards,
Alexey.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] elevator: remove second argument in elevator_init() Alexey Klimov <klimov.linux@gmail.com> - 2016-09-27 02:20 +0200

csiph-web