Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491553

Re: [PATCH v3 net-next 0/3] net: bcmgenet: only use new api ethtool_{get|set}_link_ksettings

Show all headers | View raw

On 09/26/2016 01:31 PM, Philippe Reynes wrote:
> Some times ago, a serie of patches were committed :
> - commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device")
> - commit 6b352ebccbcf ("net: ethernet: broadcom: bcmgenet: use new api ethtool_{get|set}_link_ksettings")
> The first patch add a regression on this driver, so it should be reverted.
> As the second patch depend on the former, it should be reverted too.
> 
> The first patch is buggy because there is a "trick" in this driver.
> The structure phydev is kept in the private data when the interface
> go down, and used when the interface go up to enable the phy before
> the function phy_connect is called.
> 
> I don't have this hardware, neither the datasheet. So I won't
> update the driver to avoid this trick.
> 
> But the real goal of the first serie was to move to the new api
> ethtool_{get|set}_link_ksettings. So I provide a new version of
> the patch without the "cleaning" of driver to use the phydev
> store in the net_device structure.

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 net-next 0/3] net: bcmgenet: only use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-09-26 22:40 +0200
  [PATCH v3 net-next 1/3] Revert "net: ethernet: bcmgenet: use new api ethtool_{get|set}_link_ksettings" Philippe Reynes <tremyfr@gmail.com> - 2016-09-26 22:40 +0200
  [PATCH v3 net-next 2/3] Revert "net: ethernet: bcmgenet: use phydev from struct net_device" Philippe Reynes <tremyfr@gmail.com> - 2016-09-26 22:40 +0200
  Re: [PATCH v3 net-next 0/3] net: bcmgenet: only use new api  ethtool_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-09-26 23:20 +0200
  Re: [PATCH v3 net-next 0/3] net: bcmgenet: only use new api  ethtool_{get|set}_link_ksettings David Miller <davem@davemloft.net> - 2016-09-27 13:50 +0200

csiph-web