Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using movable_node

From	Reza Arbab <arbab@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using movable_node
Date	2016-09-26 22:50 +0200
Message-ID	<slL0B-7W-3@gated-at.bofh.it> (permalink)
References	<slmvf-1Fh-7@gated-at.bofh.it> <slmvf-1Fh-13@gated-at.bofh.it> <slGki-5BO-29@gated-at.bofh.it>
Organization	IBM Linux Technology Center

Show all headers | View raw

On Mon, Sep 26, 2016 at 09:17:43PM +0530, Aneesh Kumar K.V wrote:
>> +	/* bottom-up allocation may have been set by movable_node */
>> +	memblock_set_bottom_up(false);
>> +
>
>By then we have done few memblock allocation right ?

Yes, some allocations do occur while bottom-up is set.

>IMHO, we should do this early enough in prom.c after we do 
>parse_early_param, with a comment there explaining that, we don't 
>really support hotplug memblock and when we do that, this should be 
>moved to a place where we can handle memblock allocation such that we 
>avoid spreading memblock allocation to movable node.

Sure, we can do it earlier. The only consideration is that any potential 
calls to memblock_mark_hotplug() happen before we reset to top-down.  
Since we don't do that at all on power, the call can go anywhere.

-- 
Reza Arbab

Thread

[PATCH v3 0/5] powerpc/mm: movable hotplug memory nodes Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-25 20:40 +0200
  [PATCH v3 2/5] drivers/of: do not add memory for unavailable nodes Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-25 20:40 +0200
  [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using movable_node Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-25 20:40 +0200
    Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using movable_node "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-26 17:50 +0200
      Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when  using movable_node Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-26 22:50 +0200
    Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when  using movable_node Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-09-26 23:20 +0200
      Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when  using movable_node Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-27 02:20 +0200
        Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using  movable_node Balbir Singh <bsingharora@gmail.com> - 2016-10-04 02:50 +0200
          Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when  using movable_node Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-10-04 22:30 +0200
  [PATCH v3 3/5] powerpc/mm: allow memory hotplug into a memoryless node Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-25 20:40 +0200
  [PATCH v3 5/5] mm: enable CONFIG_MOVABLE_NODE on powerpc Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-25 20:40 +0200
    Re: [PATCH v3 5/5] mm: enable CONFIG_MOVABLE_NODE on powerpc "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-09-26 17:50 +0200
    Re: [PATCH v3 5/5] mm: enable CONFIG_MOVABLE_NODE on powerpc Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-09-26 23:20 +0200
      Re: [PATCH v3 5/5] mm: enable CONFIG_MOVABLE_NODE on powerpc Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-27 02:20 +0200
  [PATCH v3 1/5] drivers/of: introduce of_fdt_is_available() Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-25 20:40 +0200
    Re: [PATCH v3 1/5] drivers/of: introduce of_fdt_is_available() Rob Herring <robh+dt@kernel.org> - 2016-10-03 17:30 +0200

csiph-web