Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491323

Re: [PATCH v3] bpf: Set register type according to is_valid_access()

Show all headers | View raw

On 09/24/2016 08:01 PM, Mickaël Salaün wrote:
> This prevent future potential pointer leaks when an unprivileged eBPF
> program will read a pointer value from its context. Even if
> is_valid_access() returns a pointer type, the eBPF verifier replace it
> with UNKNOWN_VALUE. The register value that contains a kernel address is
> then allowed to leak. Moreover, this fix allows unprivileged eBPF
> programs to use functions with (legitimate) pointer arguments.
>
> Not an issue currently since reg_type is only set for PTR_TO_PACKET or
> PTR_TO_PACKET_END in XDP and TC programs that can only be loaded as
> privileged. For now, the only unprivileged eBPF program allowed is for
> socket filtering and all the types from its context are UNKNOWN_VALUE.
> However, this fix is important for future unprivileged eBPF programs
> which could use pointers in their context.
>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>

Seems okay to me:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] bpf: Set register type according to is_valid_access() Mickaël Salaün <mic@digikod.net> - 2016-09-24 20:10 +0200
  Re: [PATCH v3] bpf: Set register type according to is_valid_access() Daniel Borkmann <daniel@iogearbox.net> - 2016-09-26 16:50 +0200
    Re: [PATCH v3] bpf: Set register type according to is_valid_access() Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-09-26 20:00 +0200
  Re: [PATCH v3] bpf: Set register type according to  is_valid_access() David Miller <davem@davemloft.net> - 2016-09-27 10:00 +0200

csiph-web