Re: [PATCH 11/13] nvme: switch to use pci_alloc_irq_vectors

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/13] nvme: switch to use pci_alloc_irq_vectors
Date	2016-09-26 17:10 +0200
Message-ID	<slFHz-5oB-9@gated-at.bofh.it> (permalink)
References	<shjcB-1Ui-7@gated-at.bofh.it> <shjmi-1XX-41@gated-at.bofh.it> <skH8J-1e4-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 23, 2016 at 03:21:14PM -0700, Sagi Grimberg wrote:
> Question: is using pci_alloc_irq_vectors() obligated for
> supplying blk-mq with the device affinity mask?

No, but it's very useful.  We'll need equivalents for other busses
that provide multipl vectors and vector spreading.

> If I do this completely-untested [1] what will happen?

Everything will be crashing and burning because you call to_pci_dev on
something that's not a PCI dev?

For the next merge window I plan to wire up the affinity information
for the RDMA code, and I will add a counterpart to blk_mq_pci_map_queues
that spreads the queues over the completion vectors.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 11/13] nvme: switch to use pci_alloc_irq_vectors Sagi Grimberg <sagi@grimberg.me> - 2016-09-24 00:30 +0200
  Re: [PATCH 11/13] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig <hch@lst.de> - 2016-09-26 17:10 +0200

csiph-web