[PATCH] serial: imx: Fix DCD reading

From	Sascha Hauer <s.hauer@pengutronix.de>
Newsgroups	linux.kernel
Subject	[PATCH] serial: imx: Fix DCD reading
Date	2016-09-26 16:00 +0200
Message-ID	<slEBQ-4u5-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The USR2_DCDIN bit is tested for in register usr1. As the name
suggests the usr2 register should be used instead. This fixes
reading the Carrier detect status.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/tty/serial/imx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 0df2b1c..615c027 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -740,12 +740,13 @@ static unsigned int imx_get_hwmctrl(struct imx_port *sport)
 {
 	unsigned int tmp = TIOCM_DSR;
 	unsigned usr1 = readl(sport->port.membase + USR1);
+	unsigned usr2 = readl(sport->port.membase + USR2);
 
 	if (usr1 & USR1_RTSS)
 		tmp |= TIOCM_CTS;
 
 	/* in DCE mode DCDIN is always 0 */
-	if (!(usr1 & USR2_DCDIN))
+	if (!(usr2 & USR2_DCDIN))
 		tmp |= TIOCM_CAR;
 
 	if (sport->dte_mode)
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] serial: imx: Fix DCD reading Sascha Hauer <s.hauer@pengutronix.de> - 2016-09-26 16:00 +0200
  Re: [PATCH] serial: imx: Fix DCD reading Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-09-26 16:10 +0200
    Re: [PATCH] serial: imx: Fix DCD reading Fabio Estevam <festevam@gmail.com> - 2016-09-26 16:20 +0200
      Re: [PATCH] serial: imx: Fix DCD reading Fabio Estevam <festevam@gmail.com> - 2016-09-26 16:30 +0200
        Re: [PATCH] serial: imx: Fix DCD reading Fabio Estevam <festevam@gmail.com> - 2016-09-26 17:10 +0200
      Re: [PATCH] serial: imx: Fix DCD reading Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-09-26 16:30 +0200
  Re: [PATCH] serial: imx: Fix DCD reading Fabio Estevam <festevam@gmail.com> - 2016-09-26 16:10 +0200

csiph-web