Re: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable() throws set-but-unused error

From	Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable() throws set-but-unused error
Date	2016-09-26 13:30 +0200
Message-ID	<slCgF-3eh-13@gated-at.bofh.it> (permalink)
References	<slruV-4Hx-5@gated-at.bofh.it> <slsU1-5DD-5@gated-at.bofh.it> <sltQ5-6kR-3@gated-at.bofh.it> <slusO-6NA-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi all,

On Sun, 25 Sep 2016 20:06:19 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> exactly like you did.  It's just that with 12 characters in the hex
> format, people will still be able to cut-and-paste the hash into git
> to get the full commit details even a year from now. With just 7 hex
> digits, you may well end up in the situation where you do
> 
>     git show e23d415
> 
> and git says
> 
>     error: short SHA1 e23d415 is ambiguous.
>     fatal: ambiguous argument 'e23d415': unknown revision or path not
> in the working tree.
> 
> (it's not ambiguous today, but in a year or two it quite possibly will be).

I have already had over the years a few instances of 7 digit commit
hashes that are unique in Linus' tree but not in mine (which is a bit
of a pain if you are trying to look for context).

-- 
Cheers,
Stephen Rothwell

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [4.8-rc7, regression] fault_in_multipages_readable() throws set-but-unused error Dave Chinner <david@fromorbit.com> - 2016-09-26 02:00 +0200
  Re: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable()  throws set-but-unused error Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-26 03:30 +0200
    Re: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable()  throws set-but-unused error Dave Chinner <david@fromorbit.com> - 2016-09-26 04:30 +0200
      Re: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable()  throws set-but-unused error Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-26 05:10 +0200
        Re: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable()  throws set-but-unused error Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-26 13:30 +0200

csiph-web