Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after soft remove event

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after soft remove event
Date	Mon, 26 Sep 2016 14:10:02 +0200
Message-ID	<slCTo-3FS-11@gated-at.bofh.it> (permalink)
References	<sjO2C-8rI-1@gated-at.bofh.it> <sjPrI-XD-23@gated-at.bofh.it> <sjPUK-17j-19@gated-at.bofh.it> <sjQnM-1xc-25@gated-at.bofh.it> <skaPw-5PF-41@gated-at.bofh.it> <skb8S-6eS-11@gated-at.bofh.it> <slCA2-3kx-5@gated-at.bofh.it>
X-Original-To	Prarit Bhargava <prarit@redhat.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23.1 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	Borislav Petkov <bp@suse.de>, linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Len Brown <len.brown@intel.com>, Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Juergen Gross <jgross@suse.com>
X-Original-Date	Mon, 26 Sep 2016 13:59:40 +0200
X-Original-Message-ID	<20160926115940.GB5016@twins.programming.kicks-ass.net>
X-Original-References	<1474457973-19536-1-git-send-email-prarit@redhat.com> <20160921130428.2e7bprll64vs6h2r@pd.tnic> <57E28BFF.8060107@redhat.com> <20160921140135.i5emid4qno2o6cre@pd.tnic> <57E3C78C.5040400@redhat.com> <20160922121039.l6lnhb53os2af27x@pd.tnic> <57E90A61.60402@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1491247

Show key headers only | View raw

On Mon, Sep 26, 2016 at 07:45:37AM -0400, Prarit Bhargava wrote:
> > But then code which reads those will have to *know* that those cores are
> > offline - otherwise it would be confused by what it is reading there.
> 
> When offline, /sys/devices/system/cpuX/cpu/online is 0.  The problem is that
> when online is 0, topology disappears so there is no way to determine _the
> location_ of the offline'd thread.

As far as all that code is concerned, that CPU doesn't even have a
location anymore.

While there might be some distinction between hotplug and physical
hotplug on the user API side (I really wouldn't know), there isn't on
the kernel side.

Once you unplug a CPU, its _gone_. There isn't another hotplug operation
once you really take the CPU out.

Offline means out gone, vamoosh.

And it doesn't make sense to talk about the location of a resource
that's not there.

Thread

Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Prarit Bhargava <prarit@redhat.com> - 2016-09-26 13:50 +0200
  Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Borislav Petkov <bp@suse.de> - 2016-09-26 14:00 +0200
    Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Prarit Bhargava <prarit@redhat.com> - 2016-09-27 13:50 +0200
      Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-27 16:00 +0200
        Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Prarit Bhargava <prarit@redhat.com> - 2016-09-27 17:30 +0200
          Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Borislav Petkov <bp@suse.de> - 2016-09-28 07:10 +0200
          Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Peter Zijlstra <peterz@infradead.org> - 2016-09-28 08:50 +0200
            Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Prarit Bhargava <prarit@redhat.com> - 2016-09-28 12:10 +0200
      Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Borislav Petkov <bp@suse.de> - 2016-09-28 07:10 +0200
  Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Peter Zijlstra <peterz@infradead.org> - 2016-09-26 14:10 +0200
    Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Prarit Bhargava <prarit@redhat.com> - 2016-09-27 13:50 +0200
      Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after  soft remove event Peter Zijlstra <peterz@infradead.org> - 2016-09-27 14:00 +0200

csiph-web