Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static

From	Mathias Nyman <mathias.nyman@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static
Date	2016-09-26 12:00 +0200
Message-ID	<slARA-2d9-15@gated-at.bofh.it> (permalink)
References	<skz1w-4hK-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 23.09.2016 16:46, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>   drivers/usb/host/xhci-ring.c | 5 +++--

Hi

There's a similar patch already pending, I'm sending that one
forward after rc1 is out

http://marc.info/?l=linux-usb&m=147170676714500&w=2

-Mathias

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-23 15:50 +0200
  Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static Greg KH <gregkh@linuxfoundation.org> - 2016-09-23 17:10 +0200
    Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static Arnd Bergmann <arnd@arndb.de> - 2016-09-23 18:10 +0200
  Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-09-26 12:00 +0200

csiph-web