RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

From	"Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem
Date	2016-09-24 22:40 +0200
Message-ID	<sl1TP-5HT-11@gated-at.bofh.it> (permalink)
References	<sgVWF-2uA-21@gated-at.bofh.it> <sgVWG-2uA-45@gated-at.bofh.it> <skvqW-20S-11@gated-at.bofh.it> <skvqW-20S-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> 
> 
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Tested-by: Avri Altman <Avri.Altman@sandisk.com>
> 
> - mmc -  full functionality. One issue found that was fixed on V6: patch V6 2/9.
> - ufs - read & read counter only.  Testing is still wip.
> 
> 
> > +static int rpmb_request_verify(struct rpmb_dev *rdev, struct rpmb_data
> > +*rpmbd) {
> 
> Seems excessive - Isn't the standard should be enforced by the device?

Yes the device is responsible to detect the issues in the protocol. The rpmb_request_verify is called only for the managed interface (rpmb_cmd_req) the raw interface (rpm_cmd_seq) is going through.  Second,  we only check more or less if we can accommodate the request/response into the arguments.  If there is a specific issue  you see in this check, please let me know.

Thanks
Tomas

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB)  subsystem "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-09-24 22:40 +0200

csiph-web