Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val()
Date	2016-09-24 21:10 +0200
Message-ID	<sl0uK-4TP-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <skT0d-hj-3@gated-at.bofh.it> <skT0d-hj-1@gated-at.bofh.it> <skZp0-3Zr-1@gated-at.bofh.it> <skZIl-4oj-1@gated-at.bofh.it> <sl01H-4uy-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Again, what is the purpose of the changes?

I came also along a few source code places where their maintainers
requested the usage of a function like "kmalloc_array".

How do you think about to clarify the consistent use of programming
interfaces for Linux a bit more?


> Are you working on the code

I am trying to improve various free software (including Linux).


> and the fact that the driver is older-style hinders your progress?

Not for me directly.


> Or there are runtime improvements from your changes?

It depends on some factors.

Can an array memory allocator organise the desired data in a safer
and more efficient way than a "default approach"?


> Correctness issues?

This can be.

Do you care for source code annotations?


> I do not very much appreciate changes just to satisfy checkpatch rule
> du jour.

Do these rules contain knowledge which you give a significant value?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Input-evdev: Use kmalloc_array() in  evdev_handle_get_val() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 13:10 +0200
  Re: [PATCH 1/2] Input-evdev: Use kmalloc_array() in evdev_handle_get_val() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-09-24 20:00 +0200
    Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 20:20 +0200
      Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-09-24 20:40 +0200
        Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 21:10 +0200

csiph-web