Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490023

Re: [PATCH v3 1/3] gpiolib: Make it possible to exclude GPIOs from IRQ domain

Show all headers | View raw

On Tue, Sep 20, 2016 at 2:15 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:

> When using GPIO irqchip helpers to setup irqchip for a gpiolib based
> driver, it is not possible to select which GPIOs to add to the IRQ domain.
> Instead it just adds all GPIOs which is not always desired. For example
> there might be GPIOs that for some reason cannot generated normal
> interrupts at all.
>
> To support this we add a flag irq_need_valid_mask to struct gpio_chip. When
> this flag is set the core allocates irq_valid_mask that holds one bit for
> each GPIO the chip has. By default all bits are set but drivers can
> manipulate this using set_bit() and clear_bit() accordingly.
>
> Then when gpiochip_irqchip_add() is called, this mask is checked and all
> GPIOs with bit is set are added to the IRQ domain created for the GPIO
> chip.
>
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Yeps, exactly like this!

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] gpio / pinctrl: cherryview: Fix missing events from EC Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-20 14:20 +0200
  [PATCH v3 1/3] gpiolib: Make it possible to exclude GPIOs from IRQ domain Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-20 14:20 +0200
    Re: [PATCH v3 1/3] gpiolib: Make it possible to exclude GPIOs from  IRQ domain Linus Walleij <linus.walleij@linaro.org> - 2016-09-23 14:50 +0200
  Re: [PATCH v3 0/3] gpio / pinctrl: cherryview: Fix missing events  from EC Phidias Chiang <phidias.chiang@canonical.com> - 2016-10-11 08:30 +0200

csiph-web