[PATCH] drm/tilcdc: fix wrong error handling

From	Daniel Schultz <d.schultz@phytec.de>
Newsgroups	linux.kernel
Subject	[PATCH] drm/tilcdc: fix wrong error handling
Date	2016-09-23 13:00 +0200
Message-ID	<skwmZ-2zw-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

When 'component_bind_all' fails it should not try to unbind components
in the error handling. This will produce a null pointer kernel panic when
no component exist.

This patch changes the order of the error handling. Now, it will only
unbind components if the are bound. Otherwise, the module will jump to
an error label below.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index d278093..d491610 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -315,13 +315,13 @@ fail_irq_uninstall:
 fail_vblank_cleanup:
 	drm_vblank_cleanup(dev);
 
-fail_mode_config_cleanup:
-	drm_mode_config_cleanup(dev);
-
 fail_component_cleanup:
 	if (priv->is_componentized)
 		component_unbind_all(dev->dev, dev);
 
+fail_mode_config_cleanup:
+	drm_mode_config_cleanup(dev);
+
 fail_external_cleanup:
 	tilcdc_remove_external_encoders(dev);
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/tilcdc: fix wrong error handling Daniel Schultz <d.schultz@phytec.de> - 2016-09-23 13:00 +0200
  Re: [PATCH] drm/tilcdc: fix wrong error handling Sean Paul <seanpaul@google.com> - 2016-09-23 13:50 +0200
    Re: [PATCH] drm/tilcdc: fix wrong error handling Jyri Sarha <jsarha@ti.com> - 2016-09-23 14:10 +0200
      Re: [PATCH] drm/tilcdc: fix wrong error handling Sean Paul <seanpaul@google.com> - 2016-09-23 14:10 +0200

csiph-web