Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489795

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

Show all headers | View raw

On 2016-09-19 22:00, Florian Fainelli wrote:
> On 09/13/2016 12:24 AM, Michal Marek wrote:
>> On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote:
>>> Hi,
>>>
>>> I have a root filesystem embedding filenames that look like these:
>>>
>>> /lib/data/<vid>:<pid>
>>>
>>> these are essentially files that can be matched against an USB
>>> vendor/product id in an easy way.
>>>
>>> Now, the fun part is that this is only a problem when doing the
>>> following (using OpenWrt/LEDE as a build system):
>>>
>>> 1:
>>> - set CONFIG_INITRAMFS_SOURCE=""
>>> - build kernel modules
>>> - build my user-space tools
>>> - build the kernel image
>>> - reconfigure the kernel to now use an initramfs
>>> - build the kernel w/ initramfs
>>>
>>> and then back to step 1 with the kernel build, would I hit this error:
>>>
>>> usr/Makefile:64: *** multiple target patterns.  Stop.
>> [...]
>>> Which sorts of make sense here because the file name contains a ":"
>>> which is not escaped, so GNU Make tries to interpret it.
>>>
>>> Now the part that does not quite make sense to me is why this file is
>>> even relevant here considering that the first thing we do is set
>>> CONFIG_INITRAMFS_SOURCE="" to disable the initramfs basically.
>>
>> It is possible that we read usr/Makefile twice for some reason. But the
>> real problem is the lack of escaping. Can you try the following
>> (untested) patch?
> 
> Can you submit an official patch for this? Thanks a lot!

The % escape is wrong. I'm trying to fix it or drop this escape.

Michal

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

gen_initramfs_list.sh escaping problem or stale dependency file? Florian Fainelli <f.fainelli@gmail.com> - 2016-09-13 02:20 +0200
  Re: gen_initramfs_list.sh escaping problem or stale dependency file? Michal Marek <mmarek@suse.com> - 2016-09-13 09:30 +0200
    Re: gen_initramfs_list.sh escaping problem or stale dependency file? Florian Fainelli <f.fainelli@gmail.com> - 2016-09-13 19:30 +0200
    Re: gen_initramfs_list.sh escaping problem or stale dependency file? Florian Fainelli <f.fainelli@gmail.com> - 2016-09-19 22:10 +0200
      Re: gen_initramfs_list.sh escaping problem or stale dependency file? Michal Marek <mmarek@suse.com> - 2016-09-23 09:10 +0200
        [PATCH] initramfs: Escape colons in depfile Michal Marek <mmarek@suse.com> - 2016-09-23 10:40 +0200

csiph-web