Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

From	Joel Stanley <joel@jms.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver
Date	2016-09-23 08:10 +0200
Message-ID	<skrQl-8qj-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <sfFKh-2aV-9@gated-at.bofh.it> <sfFKh-2aV-7@gated-at.bofh.it> <sjesa-2tY-33@gated-at.bofh.it> <sjgaC-3Aa-25@gated-at.bofh.it> <skrQl-8qj-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Brendan,

On Wed, Sep 21, 2016 at 3:35 AM, Brendan Higgins
<brendanhiggins@google.com> wrote:
> First off, someone pointed out to me that the mapping that I used between
> addresses and bus numbers is not actually valid for busses 8-14.
>
> This could be fixed by checking the offset, but I am wondering if that is
> the right way to do it. It seems like this is not completely trivial so
> maybe this should be specified in the device tree? If that is the case,
> should I do this as another reg entry or go back to the way I was doing it
> before?

I don't see an alternative way to derive these numbers. As you
mention, the block of SRAM in the middle of the IP screwing up the
linear mapping.

I suggest going back to what you have in v2, with a mention in the
commit message as to why the bus property is necessary.

Cheers,

Joel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2016-09-10 04:00 +0200
  Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C  driver Rob Herring <robh@kernel.org> - 2016-09-19 23:40 +0200
    Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2016-09-20 01:30 +0200
      Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2016-09-20 20:10 +0200
        Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2016-09-21 01:10 +0200
      Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Joel Stanley <joel@jms.id.au> - 2016-09-23 08:10 +0200

csiph-web