Re: [PATCH] sched/debug: check p->se.on_rq for 'runnable tasks'

Path	csiph.com!1.us.feeder.erje.net!2.eu.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!enother.net!enother.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Zhu Yanhai <zhu.yanhai@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched/debug: check p->se.on_rq for 'runnable tasks'
Date	Fri, 23 Sep 2016 05:20:01 +0200
Message-ID	<skpbP-6H2-9@gated-at.bofh.it> (permalink)
References	<sk8Xn-4DU-1@gated-at.bofh.it> <sk973-4Wz-9@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=f55pfbN2ygzNM3arsSkdOhOX5uG+rnE3A7Sj+8MHrGg=; b=Yz0EvxvBIY7JAphGDn4k6F867D0K2jqkQnttLY1sB8hGu4byWltMWgljvOxRpJLDwY izyk3Q3J6ofePXHx+u5yHGP22X8PfBlifZyagiZDSfemwktclpScesDISmX5QLkxWuFT gAK+wKmc6/gmTcm7VYoPrH+xweeCzfOHkwyb+I2bDpM0S4tpR3IDVHXVIB1sTY5wx7o4 CrD87u3v6ysuRrUCgsnukZfcUnd/YttAp+wkld0m9zVmwzLbU2tuumwEL2WUNsp/62pM NsD9ChEO010FNKxjiCxeDHzcWp29hE8m3BICb5pd/HgpJrT2Yen3EHxkX5ppVfRWgIO/ TZ/g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=f55pfbN2ygzNM3arsSkdOhOX5uG+rnE3A7Sj+8MHrGg=; b=QRmY7G8BgSZDkbVu3PZGk0O1VnwGpmDB/CQArHyDqmeSB/gTtNf7ojaM9fXTdDR4Wq +y9/genmumDnoa487bbcvcjXS9r16aV9MY+pQtlQVhuN55hkTQJsrDdgu66i7g/JI3uV ikcIs8LfoP4UFIcnKr9a7N6musqC9fZbG7zFKCYYkY6/UsvBdS4T5TCzsgPs8Gcu4y6P jCJfCGrZeUA7Lrb/BRhAgZ8W5+FndKSYmzTH4EGdEsFWkRg1NWNke1qur2CvZfYyWKwl sBGpbthpFbpfy/eKBK6wH838YkLiCo2nBiFROBVC6pSFPtKBPQQJlpZLbrojI73h1JXF bIow==
X-Gm-Message-State	AE9vXwMH69W4g6lNpAx8l0kzzs4lDdMwo/PK6b8U/uLFm/QQGSOOp/x+CPCU8RlLhbV9qVoT0brmcVV69u6ZUg==
X-Received	by 10.176.4.9 with SMTP id 9mr2719089uav.138.1474600511849; Thu, 22 Sep 2016 20:15:11 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	14
Organization	linux.* mail to news gateway
X-Original-Cc	Zhu Yanhai <zhu.yanhai@foxmail.com>, Ingo Molnar <mingo@redhat.com>, LKML <linux-kernel@vger.kernel.org>, shanpei.csp@alibaba-inc.com, jinli.zjl@alibaba-inc.com, Zhu Yanhai <gaoyang.zyh@taobao.com>
X-Original-Date	Fri, 23 Sep 2016 11:14:51 +0800
X-Original-Message-ID	<CAC8teKXxKPsJnvNMiYb2H4HdEBqYPxfTWSUJpxHm90mEFwBsxA@mail.gmail.com>
X-Original-References	<1474537853-9096-1-git-send-email-zhu.yanhai@foxmail.com> <20160922100842.GZ5008@twins.programming.kicks-ass.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1489724

Show key headers only | View raw

2016-09-22 18:08 GMT+08:00 Peter Zijlstra <peterz@infradead.org>:
> On Thu, Sep 22, 2016 at 05:50:53PM +0800, Zhu Yanhai wrote:
>> From: Zhu Yanhai <gaoyang.zyh@taobao.com>
>>
>> I can't see why the check was removed by commit b32e86b4. Since it was not
>> relevant to the subject of the commit, I guess it was just a plain typo.
>
> No, it was very much on purpose. It shows all tasks now, which is much
> more useful if you want to generate pretty pictures from the output.
>
> Its a bit hard to make pretty pictures when tasks disappear all the
> time.

I see. Thanks for your quick reply!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sched/debug: check p->se.on_rq for 'runnable tasks' Zhu Yanhai <zhu.yanhai@foxmail.com> - 2016-09-22 12:00 +0200
  Re: [PATCH] sched/debug: check p->se.on_rq for 'runnable tasks' Peter Zijlstra <peterz@infradead.org> - 2016-09-22 12:10 +0200
    Re: [PATCH] sched/debug: check p->se.on_rq for 'runnable tasks' Zhu Yanhai <zhu.yanhai@gmail.com> - 2016-09-23 05:20 +0200

csiph-web