Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1489605

[PATCH RT 02/10] timers: wakeup all timer waiters without holding the base lock

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject [PATCH RT 02/10] timers: wakeup all timer waiters without holding the base lock
Date 2016-09-23 00:10 +0200
Message-ID <skklP-3Bb-1@gated-at.bofh.it> (permalink)
References <skkca-3ii-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


4.1.33-rt38-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

There should be no need to hold the base lock during the wakeup. There
should be no boosting involved, the wakeup list has its own lock so it
should be safe to do this without the lock.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/time/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index 5a45162ae924..b1f9e6c5bec4 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1279,8 +1279,8 @@ static inline void __run_timers(struct tvec_base *base)
 			}
 		}
 	}
-	wakeup_timer_waiters(base);
 	spin_unlock_irq(&base->lock);
+	wakeup_timer_waiters(base);
 }
 
 #ifdef CONFIG_NO_HZ_COMMON
-- 
2.8.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH RT 00/10] Linux 4.1.33-rt38-rc1 Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:00 +0200
  [PATCH RT 08/10] x86/preempt-lazy: fixup should_resched() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:00 +0200
  [PATCH RT 10/10] Linux 4.1.33-rt38-rc1 Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:00 +0200
  [PATCH RT 01/10] timers: wakeup all timer waiters Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:00 +0200
  [PATCH RT 02/10] timers: wakeup all timer waiters without holding the base lock Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:10 +0200
  Re: [PATCH RT 05/10] net: add back the missing serialization in  ip_send_unicast_reply() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:10 +0200
  [PATCH RT 07/10] fs/dcache: resched/chill only if we make no progress Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:10 +0200
  [PATCH RT 04/10] scsi/fcoe: Fix get_cpu()/put_cpu_light() imbalance in  fcoe_recv_frame() Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:10 +0200

csiph-web