Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1489595

[PATCH RT 02/10] timers: wakeup all timer waiters without holding the base lock

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject [PATCH RT 02/10] timers: wakeup all timer waiters without holding the base lock
Date 2016-09-23 00:00 +0200
Message-ID <skkca-3ii-21@gated-at.bofh.it> (permalink)
References <skk2u-3f3-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


4.4.21-rt31-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

There should be no need to hold the base lock during the wakeup. There
should be no boosting involved, the wakeup list has its own lock so it
should be safe to do this without the lock.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/time/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index d5212147ae19..603699ff9411 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1313,8 +1313,8 @@ static inline void __run_timers(struct tvec_base *base)
 			}
 		}
 	}
-	wakeup_timer_waiters(base);
 	spin_unlock_irq(&base->lock);
+	wakeup_timer_waiters(base);
 }
 
 #ifdef CONFIG_NO_HZ_COMMON
-- 
2.8.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH RT 00/10] Linux 4.4.21-rt31-rc1 Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:00 +0200
  [PATCH RT 02/10] timers: wakeup all timer waiters without holding the base lock Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:00 +0200
  [PATCH RT 03/10] sched: lazy_preempt: avoid a warning in the !RT case Steven Rostedt <rostedt@goodmis.org> - 2016-09-23 00:00 +0200

csiph-web